Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves publish-time diagnostics by surfacing function-injection problems as warnings and attempts to add legacy-compatible fragment template resolution for Jinja templates.
Changes:
- Add
warningstoPageResultand propagate function-injection warnings fromSiteEngine.render()into publish output. - Extend
publish_site()to aggregate per-page render warnings into the returnedPublishReport. - Update Jinja fragment rendering to use a new fragment-specific template resolver with “legacy” suffix probing; add tests asserting expected warnings.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_publish_warnings.py | Adds tests that assert publish reports warnings for unmet query constraints and missing fragment templates. |
| src/httk/web/templating/jinja2_engine.py | Switches fragment rendering to a new resolver intended to improve legacy suffix handling. |
| src/httk/web/publishing/static.py | Aggregates PageResult.warnings into PublishReport.warnings during publish. |
| src/httk/web/model/page.py | Adds warnings field to PageResult. |
| src/httk/web/engine/site_engine.py | Collects warnings during function injection and returns them on PageResult. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…gment_template() now reuses TEMPLATE_SUFFIXES instead of a separate hardcoded list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.