bugfix: use upstream proxy#1128
Open
BernhardRode wants to merge 1 commit intohttp-party:masterfrom
BernhardRode:feature/handle-to-proxy
Open
bugfix: use upstream proxy#1128BernhardRode wants to merge 1 commit intohttp-party:masterfrom BernhardRode:feature/handle-to-proxy
BernhardRode wants to merge 1 commit intohttp-party:masterfrom
BernhardRode:feature/handle-to-proxy
Conversation
Handle toProxy option properly and get proxy settings from environment.
This was referenced Jan 3, 2017
|
Hi, I have tested your patch, as is it's not working, below the correct code: `if (options.toProxy) { } |
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle toProxy option properly and get proxy settings from environment.
There is an option toProxy (true/false) for http-proxy. But it is never used afaiks.
This fix checks the option and uses the http/https proxy set in the environment variables.
Usage:
Sorry, for I had no time for unit tests (just needed a local hotfix ;) )... If you like the solution I could into this PR in more detail during the weekend.