Skip to content

Conversation

@httpdss
Copy link
Owner

@httpdss httpdss commented Aug 1, 2025

Summary

This PR fixes website deployment issues and improves code formatting in the JavaScript files.

Changes Made

Service Worker Fix

  • Fixed service worker registration path from /sw.js to /struct/sw.js
  • This ensures proper functionality when the site is deployed to GitHub Pages under the /struct/ path

Code Formatting Improvements

  • Improved testimonials formatting with better line breaks and readability
  • Standardized quote usage for consistency across the testimonials data
  • Updated arrow function syntax for better code consistency

Files Modified

  • site/js/advanced.js - Service worker registration path fix
  • site/js/phase3.js - Testimonials formatting improvements

Testing

  • Service worker path fix addresses GitHub Pages deployment issues
  • Code formatting improvements maintain functionality while improving readability
  • No breaking changes introduced

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Code style/formatting improvement
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • Code follows the project's style guidelines
  • Self-review of code completed
  • Changes have been tested locally
  • No new warnings or errors introduced
  • Commit messages are clear and descriptive

- Fix service worker registration path from '/sw.js' to '/struct/sw.js' for proper GitHub Pages deployment
- Improve code formatting in testimonials section with better line breaks and consistent quotes
- Update arrow function syntax for better consistency
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.04%. Comparing base (4d6a1b1) to head (3ef0b55).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   66.04%   66.04%           
=======================================
  Files          22       22           
  Lines        1240     1240           
  Branches      175      175           
=======================================
  Hits          819      819           
  Misses        384      384           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@httpdss httpdss added bug Something isn't working patch labels Aug 1, 2025
@httpdss httpdss merged commit a3d928b into main Aug 1, 2025
3 checks passed
@httpdss httpdss deleted the fix/website-service-worker-and-formatting branch August 1, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants