[pull] master from mozilla:master#1361
Merged
pull[bot] merged 85 commits intohttpsgithu:masterfrom Apr 19, 2023
Merged
Conversation
…=jandem If the key and lookup pointers are the same we don't need to check the unique ID. Differential Revision: https://phabricator.services.mozilla.com/D175737
… profile selector in the new migration wizard. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D175052
…back-reviewers,padenot Prefer timestamp from the OpenH264 decoder if available. This patch bumps the API version for the GMP plugin API. The OpenH264 library takes advatange of this. It also adds a few quality of life options. One request the GMP library logging be turned on via the "GMPLibrary" log module. One can toggle between single and multi-threaded decoding via media.gmp.decoder.multithreaded. One can toggle between single or batch decoding via media.gmp.decoder.decode_batch. Provided the OpenH264 library supports this, it will now provide the adjusted presentation timestamp from the decoder. This is necessary for encodings with B frames that may be out of order. This corresponds to the SBufferInfo::uiOutYuvTimestamp from the library. If it is not available, we will default to our historical behaviour and use the original presentation timestamp. Additionally, we now assume that H264 frames may also be provided out of order, and we provide a reorder queue to buffer the input similar to the other H264 decoders such as Apple's and Widevine's. This will ensure that regardless of the plugin output, we will provide any necessary reordering. Differential Revision: https://phabricator.services.mozilla.com/D175281
…ential-management-reviewers,devtools-reviewers,sgalich,nchevobbe You let me know if this seems appealing to you :) Differential Revision: https://phabricator.services.mozilla.com/D175382
… entire viewport. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D175727
…slateElements helper r=pdahiya,Gijs Differential Revision: https://phabricator.services.mozilla.com/D174810
…eBaseline. r=dshin This isn't needed for nsTextControlFrame because its ComputeAutoSize implementation doesn't return an unconstrained line-height for inputs, so we never end up in the UNCONSTRAINEDSIZE case, but it's needed for date/time inputs. Use GetLineHeight while at it, since it's the inflated line-height which is what we want, and may be cached so we can avoid computing it. Maybe in the future we can make date/time inputs just use nsTextControlFrame, which would prevent this from happening in the future. Depends on D175745 Differential Revision: https://phabricator.services.mozilla.com/D175746
…ntrinsicISizesDirty. r=dshin This seems to be here since nsTextControlFrame has a meaningful baseline, but it doesn't make much sense to me: * Baseline is a block axis, not inline axis measurement. * It doesn't call into the base class which seems clearly a bug (though the intrinsic isize of the input is ~fixed, doesn't depend on font metrics, so it's probably ok). My guess is that it was intended to be a debug-only check so that we could detect stale baseline values. Just remove this, and replace it by a non-fatal assert as it's done elsewhere. Differential Revision: https://phabricator.services.mozilla.com/D175745
…rame. r=dshin Seems like this should be doable, and would avoid mistakes like this in the future. Differential Revision: https://phabricator.services.mozilla.com/D175748
…ment. r=tgiles,flod,application-update-reviewers,bytesized Differential Revision: https://phabricator.services.mozilla.com/D175011
Depends on D175011 Differential Revision: https://phabricator.services.mozilla.com/D175525
…dthayer Differential Revision: https://phabricator.services.mozilla.com/D175675
…d tabs, not active tabs. r=edgar This change relaxes the check slightly. Spec requires that the tab is focused. Our existing check for "active" is additionally requiring the tab to be non-occluded. Since occlusion updates are asynchronous when the transition itself is asynchronous, this change allows rapid requests to be permitted as long as the underlying window and tab state is as expected. Differential Revision: https://phabricator.services.mozilla.com/D174983
…xit is being processed. r=edgar This change makes the parent process delay a fullscreen request if there is a pending fullscreen exit. It also changes the DOMFullscreenParent actor listener lifecycle. Once it has started handling a fullscreen request, it will remain a listener to the Document until it receives an exit event when the manager is out of fullscreen. Differential Revision: https://phabricator.services.mozilla.com/D175186
…xits. r=edgar This test aspires to be a simple example of how repeated requests to enter and exit fullscreen stress the fullscreen handling code. Differential Revision: https://phabricator.services.mozilla.com/D174797
…fluent-reviewers,flod This implements the weather suggestion result menu UI and builds on D174941. References: * [Spec]( https://www.figma.com/file/Hdi0oHB7trRcncyVAKZypO/accuweather-explorations?node-id=2421%3A62540&t=29w6wH3UYchqBxqX-1) (See "A11y review" in the sidebar) * [Clickable prototype](https://www.figma.com/proto/Hdi0oHB7trRcncyVAKZypO/accuweather-explorations?page-id=2192%3A42825&node-id=2394-52468&viewport=246%2C526%2C0.12&scaling=min-zoom&starting-point-node-id=2394%3A52468&show-proto-sidebar=1) (See "Revised 4/3" in the sidebar) There are a couple important points about the menu. First, one of the commands, "Report inaccurate location", is specific to weather suggestions, or at least location-based suggestions. I don't think it's a good idea to centralize all commands in UrlbarView, and in general I'd like to stop centralizing handling of different result types in the view and input, so I added a new provider method called `getResultCommands()`. Second, the spec calls for a menu separator and a submenu so the user can select a reason they don't want to see the result, so the return value of `getResultCommands()` is flexible enough to support those two things, and I modified `#populateResultMenu()` too. These new commands will be recorded in Glean engagement telemetry as new `engagement_type` values, same as "dismiss" and "help" currently are. This patch doesn't implement handling of two of the commands, "Report inaccurate location" and "Show less frequently", because I wanted to keep it focused on the fundamentals described above. Depends on D174941 Differential Revision: https://phabricator.services.mozilla.com/D174994
…tions r=gregtatum,fluent-reviewers,flod Displays languages as being in beta in the selectors for both the about:translations page and for in-page translations. Differential Revision: https://phabricator.services.mozilla.com/D175440
…h the old and new asserts. MANUAL PUSH: Trivial orange fix CLOSED TREE
… detect changes. r=perftest-reviewers,kshampur Currently the new platform and task names are getting stuck as the first test being analyzed. This patch fixes it by changing how those two values are setup. Differential Revision: https://phabricator.services.mozilla.com/D175246
…e__, r=ipc-reviewers,mccr8 Previously we would both send it as the routing target for the actor as well as as an implicit actor parameter. This patch keeps the same API from the caller's point of view, but avoids sending the second reference to the actor in the Send__delete__ message, which also avoids potential issues with the second reference being null under fuzzing. Differential Revision: https://phabricator.services.mozilla.com/D175545
…rror. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D175779
…n ipdl. CLOSED TREE
…rce-docs-reviewers,sylvestre - generate exported index.rst file in mach doc - stop tracking docs/mots/index.rst, add it to ignore files - add mots.yaml to sphinx-docs sparse profile - add mots to requirements Differential Revision: https://phabricator.services.mozilla.com/D170116
…jseward BaseCompiler::loadTypeDef assumes that it can use InstanceReg, but that is only true on non x86/arm32. This commit removes loadWasmGlobalPtr, as it's just a thin wrapper around loadPtr that obscures more than helps. Callers of that now just specify the register that contains the instance directly. This demystifies what's going on. We can then fix baseline to use a register it has allocated. Differential Revision: https://phabricator.services.mozilla.com/D172026
We use many variations of 'global data', 'global area', and more recently 'instance data'. I prefer 'instance data' as 'global' is ambiguous with wasm globals, which while stored in the instance are not the only thing stored there. The naming scheme for this originated when globals were the only thing stored there, so we should now change it. Depends on D172026 Differential Revision: https://phabricator.services.mozilla.com/D172027
…nce data. r=jseward We do this for type definitions, and can do this for tables and tags for consistency. Depends on D172027 Differential Revision: https://phabricator.services.mozilla.com/D172028
# ignore-this-changeset
If MOZ_CC_LOG_SHUTDOWN_SKIP is set to a non-negative integer value, then skip that many of the initial shutdown CC logs. This is useful to reduce total log size if you know the initial few logs aren't useful, because they are the largest. Differential Revision: https://phabricator.services.mozilla.com/D175797
… r=kinetik Differential Revision: https://phabricator.services.mozilla.com/D175733
…,bradwerth Differential Revision: https://phabricator.services.mozilla.com/D175812
…eviewers,nalexander,amejiamarmol Differential Revision: https://phabricator.services.mozilla.com/D175790
…es on input-date-content-size.html.
…failures. CLOSED TREE Backed out changeset a30a125f2aea (bug 1825611) Backed out changeset ee5e3b614f91 (bug 1825611) Backed out changeset c79ad1ee1e32 (bug 1825611) Backed out changeset db2d550a788b (bug 1825611)
…ow about r=sgalich,lina Differential Revision: https://phabricator.services.mozilla.com/D174834
…P is set in the environment, r=canaltinova. Differential Revision: https://phabricator.services.mozilla.com/D175512
GCC bug 109480 describes an issue we're encountering with calling protected member functions from within protected member functions. The previous workaround, removed in this revision, is a bit annoying, and must be repeated when we need to capture the return value of protected functions. Making specializations of RemoteAccessibleBase friends of other RemoteAccessibleBase specializations, while maybe a bit heavy-handed, is a cleaner solution here, particularly since we only specialize with RemoteAccessible itself. This is a workaround suggested by GCC devs in the referenced bug. Differential Revision: https://phabricator.services.mozilla.com/D175531
…ers,lsalzman Differential Revision: https://phabricator.services.mozilla.com/D175835
…s,lsalzman Differential Revision: https://phabricator.services.mozilla.com/D175836
…tureHost() when mCurrentTextureHost wraps remote texture r=gfx-reviewers,lsalzman The problem occurred when the remote texture fell back to the normal TextureHost. mCurrentTextureHost have to be cleared in WebRenderImageHost::UseTextureHost() when mCurrentTextureHost wraps remote texture. When WebRenderImageHost::UseTextureHost() is called mCurrentTextureHost is chosen in WebRenderImageHost::GetAsTextureHostForComposite(). In the GetAsTextureHostForComposite(), mCurrentTextureHost should not wrap remote texture. Differential Revision: https://phabricator.services.mozilla.com/D175838
…almeiro Depends on D175722 Differential Revision: https://phabricator.services.mozilla.com/D175723
…stem-reviewers,glandium DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D175735
…ILD CLOSED TREE be -> f0685c3723db28f23cc800fa18a036e9ffaab133 de -> 0f03154840127fb388cd4c17f5dc6e5a315ea00f en-GB -> 5e80aeaea28087d4ba0de7983f80d445ccc87cf5 es-AR -> 52e46ace2ad6f08d67f50fa3fe0d42992c99e3f0 es-CL -> bc8952fafa664cfa3782983d4f090c8c4e6116bd fur -> 3153270cd33dbcaa5c06ed5ba6636663daabdc57 ko -> eb713e0c0f3fbe77ead486e647d56b629e49d42a lo -> ccd3870af1456acfef48919ea99a13f1a4ddb26d nn-NO -> cc82f27846cacdf2b43e8aadcb3bf8bd5d611aa4 pt-BR -> b0ab3f43259ec4a0267c7104943a81067774452a sr -> 092e571cb53c96e44f3ebfd982be6d0e5647214e sv-SE -> d8bd3888fd91d9d771f9696387a47727d3050386 vi -> febfc0dff60b36514665bd1fd3f66d90b4c6cbb3
…eens r=Mardak Differential Revision: https://phabricator.services.mozilla.com/D175293
…res in browser/extensions/formautofill/test/unit/<...> CLOSED TREE
…daisuke Differential Revision: https://phabricator.services.mozilla.com/D175772
…e and not in the extensions panel. r=mconley,rpl Differential Revision: https://phabricator.services.mozilla.com/D168532
… builds. r=emilio This becomes a fatal compile error in automation (ie try). Differential Revision: https://phabricator.services.mozilla.com/D175844
…ing. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D175743
…ion failures in death test child processes. r=gbrown Gtest checks (with ASSERT_* or EXPECT_* macros) in gtest death test child processes are usually ignored with no way of manually enabling them. This patch implements a helper class, ScopedTestResultReporter, that when it is the current test reporter will print TestPartResults to stderr. Stderr of a death test child process will get printed by the parent only if the testcase failed. A death test child can only signal to the parent to fail the testcase by means of the exit code (or the absence of exit). To help signal an unexpected exit code, ScopedTestResultReporter can be made to exit the process automatically as it goes out of scope, using different exit codes depending on the death test child's test status where 0=pass, 1=nonfatal failure, and 2=fatal failure. Note that when used like this, the death test parent process must be set up to expect an exit code of 0 from the death test child process, typically through `EXPECT_EXIT(DoTestThatExits(), testing::ExitedWithCode(0), "");`. When an `EXPECT_EXIT` check fails, gtest makes sure to print stderr from the child process with the unexpected exit code (which is where the test results passed through ScopedTestResultReporter were printed). Differential Revision: https://phabricator.services.mozilla.com/D175139
…ok it up to XPCOMShutdown. r=chutten In FOG::GetSingleton(), RunOnShutdown() sets up ShutdownPhase::XPCOMShutdown to shut down glean through glean::impl::fog_shutdown(). Without this patch, when initialized directly through glean::impl::fog_init(), nothing calls fog_shutdown(). With the gtest death test that runs through the shutdown sequence (and exits) in D174094, glean then leaks a "glean.upload" thread, leading to a permorange. Differential Revision: https://phabricator.services.mozilla.com/D175454
… r=karlt This uses death tests to be able to run through the shutdown sequence without affecting the main process. Differential Revision: https://phabricator.services.mozilla.com/D174094
…r the eslint-plugin-mozilla node_modules as well. r=linter-reviewers,andi Differential Revision: https://phabricator.services.mozilla.com/D175769
…int are separated. r=Gijs,devtools-reviewers,ochameau Depends on D175769 Differential Revision: https://phabricator.services.mozilla.com/D175770
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )