[pull] master from mozilla:master#236
Merged
pull[bot] merged 9 commits intohttpsgithu:masterfrom Oct 10, 2021
Merged
Conversation
…tasks. r=nalexander This was causing issues in socket-process xpcshell tests for the gecko-based pingsender. The spi-nw configuration [1] passes `--setpref=network.http.network_access_on_socket_process.enabled=true` to xpcshell tests. The xpcshell harness reads this pref [2] to set self.mozInfo["socketprocess_networking"], and then later uses it to set MOZ_FORCE_USE_SOCKET_PROCESS in the enviroment [3]. However, the backgroundtask machinery also disables the socket process pref on startup [4]. This activates a mismatch between nsIOService::UseSocketProcess, which checks MOZ_FORCE_USE_SOCKET_PROCESS [5], and nsIOService::LaunchSocketProcess, which doesn't [6]. The net result is that necko is inoperable, because part of the system thinks there should be a socket process and part of the system thinks the converse. We could solve this mismatch by making LaunchSocketProcess check MOZ_FORCE_USE_SOCKET_PROCESS, but that would simply override the attempt to disable the socket process in backgroundtasks.js. According to Nick, disabling the socket process for background tasks was just done to avoid a crash, and that crash appears to be gone. So we just remove that special-casing. [1] https://searchfox.org/mozilla-central/rev/b847c844adf49013067281d3237e7ada24325a34/taskcluster/gecko_taskgraph/transforms/tests.py#329 [2] https://searchfox.org/mozilla-central/rev/b847c844adf49013067281d3237e7ada24325a34/testing/xpcshell/runxpcshelltests.py#1526 [3] https://searchfox.org/mozilla-central/rev/b847c844adf49013067281d3237e7ada24325a34/testing/xpcshell/runxpcshelltests.py#1198 [4] https://searchfox.org/mozilla-central/rev/b847c844adf49013067281d3237e7ada24325a34/toolkit/components/backgroundtasks/defaults/backgroundtasks.js#8 [5] https://searchfox.org/mozilla-central/rev/b847c844adf49013067281d3237e7ada24325a34/netwerk/base/nsIOService.cpp#583 [6] https://searchfox.org/mozilla-central/rev/b847c844adf49013067281d3237e7ada24325a34/netwerk/base/nsIOService.cpp#505 Differential Revision: https://phabricator.services.mozilla.com/D127906
… failures on test_recursive_frames.html. CLOSED TREE
… r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D128010
…otond Differential Revision: https://phabricator.services.mozilla.com/D127115
…ve check r=saschanaz update implementation to match spec, but exclude .canShare() Differential Revision: https://phabricator.services.mozilla.com/D125326
Synced FlushRendering() causes deadlock on Wayland. Main thread is blocked at MessageChannel::WaitForSyncNotify() and it's not processing events from system. Rendering thread is blocked at RendererOGL::UpdateAndRender() / eglQuerySurface(). Mesa is waiting for free back buffer at get_back_bo(), it's spinning wl_display_roundtrip_queue() and waiting for free buffer but it doesn't get one as main loop is blocked. Differential Revision: https://phabricator.services.mozilla.com/D127878
… pt 2); r=jmaher This completes the review of skip-if(verify) in mochitest.ini. Differential Revision: https://phabricator.services.mozilla.com/D127992
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )