Skip to content

[pull] master from getlantern:master #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Apr 6, 2023
Merged

[pull] master from getlantern:master #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30ddb32
Better logging on port filter failures
oxtoacart Apr 5, 2023
eb4bf4e
Logging origin on port filter failures
oxtoacart Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions proxyfilters/connectports.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package proxyfilters

import (
"fmt"
"net"
"net/http"
"strconv"
Expand All @@ -27,14 +28,14 @@ func RestrictConnectPorts(allowedPorts []int) filters.Filter {

port, err := strconv.Atoi(portString)
if err != nil {
return fail(cs, req, http.StatusBadRequest, "Invalid port")
return fail(cs, req, http.StatusBadRequest, fmt.Sprintf("Invalid port for %v: %v", req.Host, portString))
}

for _, p := range allowedPorts {
if port == p {
return next(cs, req)
}
}
return fail(cs, req, http.StatusForbidden, "Port not allowed")
return fail(cs, req, http.StatusForbidden, fmt.Sprintf("Port not allowed for %v: %d", req.Host, port))
})
}