[pull] master from kubernetes:master#2253
Merged
pull[bot] merged 14 commits intohttpsgithu:masterfrom Feb 26, 2025
Merged
Conversation
…Deletion` enabled.
We cannot use limit as it would apply it before filtering, which is done in cacher. Limit is not currently used, but let's remove it to be save, until filtering is implemented in store.
Remove limit support from btree store
chore(scheduler): use framework.Features in scheduler plugins
Signed-off-by: z1cheng <imchench@gmail.com>
Replace reflect.DeepEqual with cmp.Diff in pkg/scheduler tests
* Add Watch to controller roles Starting from version 1.32, the client feature `WatchListClient` has been set to `true` in `kube-controller-manager`. (commit 06a15c5) As a result, when the `kube-controller-manager` executes the `List` method, it utilizes `Watch`. However, there are some existing controller roles that include `List` but do not include `Watch`. Therefore, when processes using these controller roles execute the `List` method, `Watch` is executed first, but due to permission errors, it falls back to `List`. This PR adds `Watch` to the controller roles that include `List` but do not include `Watch`. The affected roles are as follows (prefixed with `system:controller:`): - `cronjob-controller` - `endpoint-controller` - `endpointslice-controller` - `endpointslicemirroring-controller` - `horizontal-pod-autoscaler` - `node-controller` - `pod-garbage-collector` - `storage-version-migrator-controller` Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com> * Fix Fixture Data I apologize, the Fixture Data modifications were missed. Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com> * Add ControllerRoles Test Added a test to check that if a controller role includes `List`, it also includes `Watch`. Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com> * Fix typo Co-authored-by: Jordan Liggitt <jordan@liggitt.net> * Add Additional Tests Added tests to check that if NodeRules, ClusterRoles, and NamespaceRoles include `List`, it also include `Watch`. Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com> --------- Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com> Co-authored-by: Jordan Liggitt <jordan@liggitt.net>
[KEP-5080]Ordered Namespace Deletion
Implement chunking for gzip encoder in deferredResponseWriter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )