Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

@Lance52259
Copy link
Contributor

@Lance52259 Lance52259 commented Feb 20, 2021

What this PR does / why we need it:
According to server group API, server group supports members add and remove operation.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

NONE

Special notes for your reviewer:

Release note:

1. sdk supports members add and remove operation.
2. add unit test function.

Unit tests

go test -v
=== RUN   TestAddMember
--- PASS: TestAddMember (0.00s)
=== RUN   TestRemoveMember
--- PASS: TestRemoveMember (0.00s)
PASS
ok      github.com/huaweicloud/golangsdk/openstack/ecs/v1/cloudservers/testing  0.011s

@coveralls
Copy link

coveralls commented Feb 20, 2021

Pull Request Test Coverage Report for Build 1138

  • 13 of 16 (81.25%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 68.047%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/compute/v2/extensions/servergroups/requests.go 10 13 76.92%
Totals Coverage Status
Change from base Build 1136: 0.01%
Covered Lines: 11523
Relevant Lines: 16934

💛 - Coveralls

@Lance52259 Lance52259 force-pushed the ServerGroupPatch branch 10 times, most recently from a5a3ed7 to b021cc9 Compare February 23, 2021 08:03
@ShiChangkuo ShiChangkuo merged commit 95b96c6 into huaweicloud:master Feb 23, 2021
@Lance52259 Lance52259 deleted the ServerGroupPatch branch April 2, 2021 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants