This repository was archived by the owner on Aug 31, 2021. It is now read-only.
VPC subnet supports IPv6 enable #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1167
💛 - Coveralls |
Lance52259
force-pushed
the
br_IPv6_enable_active
branch
from
5c72baa to
969fea5
Compare
ShiChangkuo
reviewed
Mar 12, 2021
| GatewayIP string `json:"gateway_ip"` | ||
|
|
||
| //Specifies whether the IPv6 function is enabled for the subnet. | ||
| EnableIPv6 *bool `json:"ipv6_enable"` |
Collaborator
There was a problem hiding this comment.
should declare it as bool not a pointer in response result.
Contributor
Author
There was a problem hiding this comment.
Already update all EnableIPv6 to pointer
Lance52259
force-pushed
the
br_IPv6_enable_active
branch
from
969fea5 to
73dab1c
Compare
ShiChangkuo
pushed a commit
that referenced
this pull request
Mar 16, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
According to HUAWEI CLOUD API, VPC subent can enable IPv6 by ipv6_enable parameter.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged):Special notes for your reviewer:
Release note: