Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

@Lance52259
Copy link
Contributor

@Lance52259 Lance52259 commented Mar 16, 2021

What this PR does / why we need it:
CCE cluster API supports deleting associated items, such as efs, eni, evs, net, obs and sfs.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

NONE

Special notes for your reviewer:

Release note:

1. new enum value to select the associated resource to be deleted.

Acceptance Steps Performed

go test -v -run TestDeleteWithOptsV3Cluster
=== RUN   TestDeleteWithOptsV3Cluster
--- PASS: TestDeleteWithOptsV3Cluster (0.00s)
PASS
ok      github.com/huaweicloud/golangsdk/openstack/cce/v3/clusters/testing      0.019s

@Lance52259 Lance52259 force-pushed the br_cce_associated_delete_active branch from 5e627e7 to d2b490a Compare March 18, 2021 02:31
@coveralls
Copy link

coveralls commented Mar 18, 2021

Pull Request Test Coverage Report for Build 1200

  • 16 of 18 (88.89%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 68.171%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/cce/v3/clusters/requests.go 16 18 88.89%
Totals Coverage Status
Change from base Build 1197: 0.02%
Covered Lines: 11559
Relevant Lines: 16956

💛 - Coveralls

@Lance52259 Lance52259 force-pushed the br_cce_associated_delete_active branch from d2b490a to 0e6e478 Compare March 18, 2021 03:14
@Lance52259 Lance52259 force-pushed the br_cce_associated_delete_active branch from 0e6e478 to e452dc3 Compare March 18, 2021 06:45
@Lance52259 Lance52259 force-pushed the br_cce_associated_delete_active branch from e452dc3 to da46a93 Compare March 23, 2021 03:35
@ShiChangkuo ShiChangkuo merged commit 1b40500 into huaweicloud:master Mar 23, 2021
@Lance52259 Lance52259 deleted the br_cce_associated_delete_active branch April 2, 2021 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants