Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

@Jason-Zhang9309
Copy link
Collaborator

@Jason-Zhang9309 Jason-Zhang9309 commented Mar 31, 2021

What this PR does / why we need it:

add elb_v2 loadbalancers

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Test results:

go test -run Test -v
=== RUN   TestListLoadbalancers
--- PASS: TestListLoadbalancers (0.00s)
=== RUN   TestListAllLoadbalancers
--- PASS: TestListAllLoadbalancers (0.00s)
=== RUN   TestCreateLoadbalancer
--- PASS: TestCreateLoadbalancer (0.00s)
=== RUN   TestRequiredCreateOpts
--- PASS: TestRequiredCreateOpts (0.00s)
=== RUN   TestGetLoadbalancer
--- PASS: TestGetLoadbalancer (0.00s)
=== RUN   TestGetLoadbalancerStatusesTree
--- PASS: TestGetLoadbalancerStatusesTree (0.00s)
=== RUN   TestDeleteLoadbalancer
--- PASS: TestDeleteLoadbalancer (0.00s)
=== RUN   TestUpdateLoadbalancer
--- PASS: TestUpdateLoadbalancer (0.00s)
=== RUN   TestCascadingDeleteLoadbalancer
--- PASS: TestCascadingDeleteLoadbalancer (0.00s)
PASS
ok      github.com/huaweicloud/golangsdk/openstack/networking/v2/extensions/elb_v2/loadbalancers/testing        0.019s

@Jason-Zhang9309 Jason-Zhang9309 changed the title add elv_v2 loadbalancers add elb_v2 loadbalancers Mar 31, 2021
@coveralls
Copy link

coveralls commented Mar 31, 2021

Pull Request Test Coverage Report for Build 1224

  • 95 of 102 (93.14%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 68.32%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/elb/v2/loadbalancers/results.go 32 34 94.12%
openstack/elb/v2/loadbalancers/requests.go 54 59 91.53%
Totals Coverage Status
Change from base Build 1220: 0.1%
Covered Lines: 11654
Relevant Lines: 17058

💛 - Coveralls

@Jason-Zhang9309 Jason-Zhang9309 force-pushed the dev-elb branch 5 times, most recently from 48fbdae to 61d7cf2 Compare April 2, 2021 02:12
@ShiChangkuo ShiChangkuo merged commit cf229b8 into huaweicloud:master Apr 2, 2021
@Jason-Zhang9309 Jason-Zhang9309 deleted the dev-elb branch April 6, 2021 08:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants