This repository was archived by the owner on Aug 31, 2021. It is now read-only.
enhance the sdk of cce addon to support listing addon instances #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason-Zhang9309
force-pushed
the
dev-cce-addon
branch
2 times, most recently
from
3d5025a to
9344f42
Compare
Pull Request Test Coverage Report for Build 1275
💛 - Coveralls |
ShiChangkuo
suggested changes
Apr 14, 2021
| return CCEServiceURL(client, cluster_id, rootPath, id+"?cluster_id="+cluster_id) | ||
| } | ||
|
|
||
| func resourceListURL(client *golangsdk.ServiceClient, cluster_id string) string { |
Collaborator
There was a problem hiding this comment.
we can use BuildQueryString to add query parameters
openstack/cce/v3/addons/urls.go
Outdated
| } | ||
|
|
||
| func CCEServiceURL(client *golangsdk.ServiceClient, cluster_id string, parts ...string) string { | ||
| rbUrl := "https://" + cluster_id + "." + client.ResourceBaseURL()[8:] |
Collaborator
There was a problem hiding this comment.
this line is hard to understand, suggest to use net/url package to generate it.
openstack/cce/v3/addons/requests.go
Outdated
| // List returns collection of addons. | ||
| func List(client *golangsdk.ServiceClient, clusterID string, opts ListOpts) ([]Addon, error) { | ||
| var r ListResult | ||
| _, r.Err = client.Get(resourceListURL(client, clusterID), &r.Body, &golangsdk.RequestOpts{ |
Collaborator
There was a problem hiding this comment.
dose the RequestOpts is essential？
openstack/cce/v3/addons/requests.go
Outdated
| } | ||
| } | ||
| } else { | ||
| refinedAddons = addons |
Collaborator
There was a problem hiding this comment.
looks this line is unnecessary.
openstack/cce/v3/addons/requests.go
Outdated
| matched = true | ||
|
|
||
| for key, value := range m { | ||
| if sVal := GetStructNestedField(&addon, key, value.Driller); !(sVal == value.Value) { |
Collaborator
There was a problem hiding this comment.
s/!(sVal == value.Value)/sVal != value.Value/ ?
Jason-Zhang9309
force-pushed
the
dev-cce-addon
branch
2 times, most recently
from
0e919cf to
4f23d9b
Compare
Jason-Zhang9309
force-pushed
the
dev-cce-addon
branch
from
4f23d9b to
78bf6c3
Compare
ShiChangkuo
approved these changes
Apr 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
enhance the sdk of cce addon to support listing addon instances
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: