Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

@Lance52259
Copy link
Contributor

@Lance52259 Lance52259 commented Apr 24, 2021

What this PR does / why we need it:
According to existing demands, it is now necessary to support CBR policy related interface functions.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

NONE

Special notes for your reviewer:

Release note:

1. new CBR vault sdk supported
2. new sdk test supported

Acceptance Steps Performed

go test -v -run Test
=== RUN   TestCreateV3VaultsMarshall
--- PASS: TestCreateV3VaultsMarshall (0.00s)
=== RUN   TestCreateV3Vault
--- PASS: TestCreateV3Vault (0.00s)
=== RUN   TestGetV3Vault
--- PASS: TestGetV3Vault (0.00s)
=== RUN   TestUpdateV3Vault
--- PASS: TestUpdateV3Vault (0.00s)
=== RUN   TestDeleteV3Vault
--- PASS: TestDeleteV3Vault (0.00s)
=== RUN   TestListV3Vault
--- PASS: TestListV3Vault (0.00s)
=== RUN   TestPolicyBindingV3Vault
--- PASS: TestPolicyBindingV3Vault (0.00s)
=== RUN   TestPolicyUnbindingV3Vault
--- PASS: TestPolicyUnbindingV3Vault (0.00s)
=== RUN   TestAssociateResourcesV3Vault
--- PASS: TestAssociateResourcesV3Vault (0.00s)
=== RUN   TestDissociateResourcesV3Vault
--- PASS: TestDissociateResourcesV3Vault (0.00s)
PASS
ok      github.com/huaweicloud/golangsdk/openstack/cbr/v3/vaults/testing        0.021s

@coveralls
Copy link

coveralls commented Apr 24, 2021

Pull Request Test Coverage Report for Build 1287

  • 141 of 174 (81.03%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 68.423%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/cbr/v3/vaults/urls.go 18 21 85.71%
openstack/cbr/v3/vaults/results.go 44 52 84.62%
openstack/cbr/v3/vaults/requests.go 79 101 78.22%
Totals Coverage Status
Change from base Build 1281: 0.1%
Covered Lines: 11870
Relevant Lines: 17348

💛 - Coveralls

@Lance52259 Lance52259 force-pushed the br_cbr_vaults_active branch from 0b8a5e2 to aaa815f Compare April 24, 2021 09:13
@Lance52259 Lance52259 force-pushed the br_cbr_vaults_active branch from aaa815f to f9d087e Compare April 25, 2021 01:29
@ShiChangkuo ShiChangkuo merged commit 8b86d72 into huaweicloud:master Apr 25, 2021
@Lance52259 Lance52259 deleted the br_cbr_vaults_active branch April 26, 2021 02:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants