This repository was archived by the owner on Aug 31, 2021. It is now read-only.
New ECS powers sdk supported #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lance52259
changed the title
Pull Request Test Coverage Report for Build 1333
💛 - Coveralls |
ShiChangkuo
reviewed
May 14, 2021
openstack/ecs/v1/powers/requests.go
Outdated
Comment on lines
18
to
19
| ToPowerOnMap() (map[string]interface{}, error) | ||
| ToPowerOffMap() (map[string]interface{}, error) |
Collaborator
There was a problem hiding this comment.
can we use ToPowerAction(action string) (map[string]interface{}, error) ?
then we can do more actions into one interface
Contributor
Author
There was a problem hiding this comment.
more actions can be supported with ToPowerActionMap (return one interface result).
openstack/ecs/v1/powers/requests.go
Outdated
| return | ||
| } | ||
|
|
||
| func PowerOff(client *golangsdk.ServiceClient, opts PowerOptsBuilder) (r cloudservers.JobResult) { |
Collaborator
There was a problem hiding this comment.
reboot action is missing
Contributor
Author
There was a problem hiding this comment.
thx, the function is supports power off/on and reboot now.
Lance52259
changed the title
Lance52259
force-pushed
the
br_ecs_power_active
branch
4 times, most recently
from
512157a to
8e4389f
Compare
Lance52259
changed the title
ShiChangkuo
reviewed
May 15, 2021
| ToPowerActionMap(option string) (map[string]interface{}, error) | ||
| } | ||
|
|
||
| func (opts PowerOpts) ToPowerActionMap(option string) (map[string]interface{}, error) { |
Collaborator
There was a problem hiding this comment.
suggest to add more comments about the valid vaules of option
Lance52259
force-pushed
the
br_ecs_power_active
branch
2 times, most recently
from
7149a03 to
7419d19
Compare
- remove invalid sdk and related functions - new functions of batch power on and off
Lance52259
force-pushed
the
br_ecs_power_active
branch
from
7419d19 to
e580287
Compare
ShiChangkuo
added a commit
that referenced
this pull request
May 17, 2021
This reverts commit 6068580.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This sdk supports ECS instance to power on and power off.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: