Added ability to specify permissions for collaborators #675
Conversation
|
Running mvn formatter:format refuses to format the file |
|
Hm, not sure why the formatting isn't happening. Have you tried |
bitwiseman
left a comment
bitwiseman
left a comment
There was a problem hiding this comment.
Thanks for the submission.
Good start (now that I can see the change. :)
We'll need tests for these new methods as well.
|
@jimmysombrero |
I was working in Windows, but switched to my Mac, which fixed the formatting issues I was having. My weekend project for this weekend is to add the missing methods back and write tests for the new methods. I was trying to wrap my head around how the json configuration files for WireMock are created then decided to follow the instructions in CONTRIBUTING.md and see what happens. |
|
If following the CONTRIBUTING doesn't basically "just work", I'm committed to fixing it. That's what it's there for. 😄 |
added tests for addCollaborators()
…mbrero/github-api into collaborator-permissions
Mark old addCollaborators methods depricated
…mbrero/github-api into collaborator-permissions
…mbrero/github-api into collaborator-permissions
bitwiseman
left a comment
bitwiseman
left a comment
There was a problem hiding this comment.
Thanks for adding the test.
I realize I've given another round of suggestions/questions - I don't like making people go around more than once.
Now that we have a test, if you don't have time to address my comment, I'm willing to finish this PR up. It is up to you.
updated javadoc comments for addCollaborators methods combined both modifyCollaborators methods into one method updated addColloaborators test to match new method signature
2 participants
Modified the addCollaborators methods to require a GHOrganization.Permission parameter in order allow the API to add external collaborators with varying levels of permissions. Added a second modifyCollaborators method with a signature that accepts a GHOrganization.Permission parameter.