Derek furst/datasets feature retract #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ml. Added retracted_reason, provider_info, and sub_status.
#Todo: add in internal method calls to entity api for normalized entity dict. Had problems with testing involving neo4j version incompatibility. temporarily have hard coded username/password rather than using the app.config. Also needed to replace from neo4j.exceptions import TransactionError with from neo4j import exceptions. this will be reverted after my local testing
…ons. Performing a push every so often because my virtual machine has become unstable.
…n changes. TODO: Currently only the first ID entered has the user's group and the published status verified. Need to check for each item in a revision chain.
…id is either published, or the user has the appropriate auth, for each subsequent "next revision" it checks if the dataset is published. If the dataset is not published, and the user does not have the appropriate authorization, the dataset will not be added, and the previous revision will have its "next_revision_uuid" field removed.
…l testing. Certain hard coded values are now values from the app.cfg. Also, instances of neo4.exceptions.TransactionError() have been changed back to just TransactionError(). This is done in anticipation of pulling new changes from test-release
…atasets-feature-retract
Allows users with HuBMAP-Data-Admin group access to retract published datasets, which gives them a sub_status: deprecated property. Takes as input a json file with a required field retraction_reason. This property is also updated. This uses a lot of the code from update_entities to achieve the adding of new properties to existing datasets. Needs tested and much more QA before moving to the next stage.
…is branch now only includes /datasets/<id>/retract and not datasets/<id>/revisions.
…gers for values not supplied by the user. Added documentation and removed a lot of redundant code
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following merged PR #227 but for TEST