Skip to content

Fixed an issue in datasets/<id>/revisions. Query parameter was not im… #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuanzhou merged 1 commit into from
Sep 28, 2021
Merged

Fixed an issue in datasets/<id>/revisions. Query parameter was not im… #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1970,10 +1970,11 @@ def get_dataset_revision_number(id):
@app.route('/datasets/<id>/revisions', methods=['GET'])
def get_revisions_list(id):
# By default, do not return dataset. Only return dataset if return_dataset is true
include_dataset = False
args = request.args
if "include_dataset" in args and args['include_dataset'] and type(args['include_dataset']) is bool:
include_dataset = args['include_dataset']
show_dataset = False
if bool(request.args):
include_dataset = request.args.get('include_dataset')
if (include_dataset is not None) and (include_dataset.lower() == 'true'):
show_dataset = True
# Token is not required, but if an invalid token provided,
# we need to tell the client with a 401 error
validate_token_if_auth_header_exists(request)
Expand Down Expand Up @@ -2028,10 +2029,10 @@ def get_revisions_list(id):
for revision in normalized_revisions_list:
result = {
'revision_number': revision_number,
'dataset_uuid': revision['uuid'],
'dataset_uuid': revision['uuid']
}
if include_dataset is True:
result['dataset']: revision
if show_dataset:
result['dataset'] = revision
results.append(result)
revision_number -= 1

Expand Down