Skip to content

change revisions method to not specify dataset type #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2021
Merged

change revisions method to not specify dataset type #272

merged 3 commits into from
Dec 15, 2021

Conversation

@shirey
Copy link
Member

@shirey shirey commented Dec 10, 2021 •
edited
Loading

Per request from John Conroy:

  • change output to use uuid instead of dataset_uuid
  • provide a second, not specific dataset route /entities/<id>/revisions

@shirey shirey marked this pull request as draft December 10, 2021 15:48
@shirey shirey changed the title change revision return property dataset_uuid to uuid change revisions method to not specify dataset type Dec 10, 2021
@shirey shirey changed the base branch from test-release to dev-integrate December 13, 2021 15:24
@shirey shirey marked this pull request as ready for review December 13, 2021 15:25
yuanzhou
yuanzhou approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@yuanzhou yuanzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also updated the yaml spec to reflect this change: 538d8c2

I'll just go ahead and add the new endpoint in Gateway as well.

@yuanzhou yuanzhou mentioned this pull request Dec 13, 2021
Merged
DerekFurstPitt
DerekFurstPitt approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@DerekFurstPitt DerekFurstPitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DerekFurstPitt DerekFurstPitt merged commit 9f84994 into dev-integrate Dec 15, 2021
@yuanzhou yuanzhou mentioned this pull request Dec 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuanzhou yuanzhou yuanzhou approved these changes

@DerekFurstPitt DerekFurstPitt DerekFurstPitt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shirey @yuanzhou @DerekFurstPitt