NickAkhmetov/CAT-1488 Update portal-visualization#1003
Merged
Conversation
- Implemented _get_parents and _get_parent_datasets functions to fetch parent datasets. - Enhanced add_assay_details to check parent datasets for visualization. - Updated test cases to use mock_transformation_resources for consistency.
portal-visualization to 0.5.0portal-visualization
john-conroy
approved these changes
Mar 3, 2026
yuanzhou
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the portal-visualization dependency to the latest minor version and updates the
add_assay_detailsfunction to properly setvisualization: truefor datasets that rely on parent datasets to be visualized.The previous approach did not work because the
descendantobject that was being updated to set that value does not persist its changes - only thedocpassed toadd_assay_detailsis affected.The updated approach will set
visualization: truefor: