Skip to content

NickAkhmetov/CAT-1488 Update portal-visualization#1003

Merged
yuanzhou merged 6 commits into
dev-integratefrom
nickakhmetov/cat-1488-update-portal-vis
Mar 6, 2026
Merged

NickAkhmetov/CAT-1488 Update portal-visualization#1003
yuanzhou merged 6 commits into
dev-integratefrom
nickakhmetov/cat-1488-update-portal-vis

Conversation

@NickAkhmetov
Copy link
Copy Markdown
Contributor

This PR updates the portal-visualization dependency to the latest minor version and updates the add_assay_details function to properly set visualization: true for datasets that rely on parent datasets to be visualized.

The previous approach did not work because the descendant object that was being updated to set that value does not persist its changes - only the doc passed to add_assay_details is affected.

The updated approach will set visualization: true for:

  • All standard visualizable datasets (i.e. fully self-contained processed datasets)
  • Datasets with image pyramid supports
  • Datasets that rely on parent datasets (e.g. segmentation masks and image pyramids).

- Implemented _get_parents and _get_parent_datasets functions to fetch parent datasets.
- Enhanced add_assay_details to check parent datasets for visualization.
- Updated test cases to use mock_transformation_resources for consistency.
@NickAkhmetov NickAkhmetov requested a review from yuanzhou as a code owner March 3, 2026 17:42
@NickAkhmetov NickAkhmetov changed the title NickAkhmetov/CAT-1488 Update portal-visualization to 0.5.0 NickAkhmetov/CAT-1488 Update portal-visualization Mar 3, 2026
@NickAkhmetov NickAkhmetov requested a review from john-conroy March 3, 2026 19:55
@yuanzhou yuanzhou changed the base branch from main to dev-integrate March 6, 2026 13:00
@yuanzhou yuanzhou merged commit 8eafdba into dev-integrate Mar 6, 2026
4 checks passed
@yuanzhou yuanzhou deleted the nickakhmetov/cat-1488-update-portal-vis branch March 11, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants