Conversation
- Update MARKETING_VERSION to 1.3.1 and CURRENT_PROJECT_VERSION to 6 - Remove update status section from AboutView (Sparkle handles its own UI) - Remove unused state variables (isCheckingUpdates, updateStatus, updateAvailable) Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
- Change ScreenDetector.hasPermission() from async to sync - CGPreflightScreenCaptureAccess() is synchronous, no need for async - Update all call sites to remove await where appropriate - Keep CaptureManager.hasPermission with get async for actor isolation Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
📝 Walkthrough概述此 PR 将应用版本从 1.3.0 更新至 1.3.1,简化了 About 视图中的更新状态管理 UI,并将 ScreenDetector.hasPermission 方法从异步转换为同步调用,影响权限检查的整个流程。 变更内容
预计代码审查工作量🎯 3 (中等复杂度) | ⏱️ ~20 分钟 可能相关的 PR
庆祝诗
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScreenDetector.hasPermission()from async to syncCGPreflightScreenCaptureAccess()is synchronous, no need for async wrapperCaptureManager.hasPermissionwithget asyncfor actor isolationIssue
Permissions showed unauthorized even when granted in System Settings
Root Cause
The async wrapper on
hasPermission()was causing timing issues with permission checksSolution
Make the underlying function synchronous since
CGPreflightScreenCaptureAccess()is already synchronousSummary by CodeRabbit
发布说明
Bug Fixes
Refactor
Chores