fix: use CGRequestScreenCaptureAccess to request permission#34
Merged
fix: use CGRequestScreenCaptureAccess to request permission#34
Conversation
- Replace SCShareableContent.current with CGPreflightScreenCaptureAccess() - This API is deprecated in macOS 15 but still works and does NOT trigger dialog - SCShareableContent.current triggers system permission dialog on every call Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
- Call CGRequestScreenCaptureAccess() when requesting permission - Use CGPreflightScreenCaptureAccess() directly for checking (sync, no async) - Start polling for permission status after opening System Settings Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough本PR重构屏幕录制权限检查机制,将多个组件的异步权限验证改为同步检查,使用系统API CGPreflightScreenCaptureAccess()和CGRequestScreenCaptureAccess()替代ScreenDetector的异步流程。 Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CGRequestScreenCaptureAccess()when requesting permission (not just open System Settings)CGPreflightScreenCaptureAccess()directly for checking (synchronous, no async)Issue
Permission status still showed unauthorized after granting in System Settings
Solution
CGRequestScreenCaptureAccess()properly requests permissionSummary by CodeRabbit
发布说明