fix: add Build Phase to sign frameworks with ad-hoc#36
Merged
Conversation
- Remove CODE_SIGNING_REQUIRED=NO and CODE_SIGNING_ALLOWED=NO - Add explicit codesign --force --sign - for app bundle - Ensures consistent signing across builds for permission persistence Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
- Added PBXShellScriptBuildPhase to re-sign embedded frameworks - Fixes 'different Team IDs' error when using ad-hoc signing - Sparkle.framework needs matching signature with main app Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough本PR调整了iOS应用的代码签名策略,从显式禁用改为自动签名风格,并为框架签名添加了新的构建阶段。同时改进了屏幕录制权限检查逻辑,采用多重验证方法以提升可靠性。 Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Feb 28, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue
App crashed on launch with:
mapping process and mapped file have different Team IDsSolution
Run Script Build Phase that signs all frameworks in Contents/Frameworks with ad-hoc signature when building with ad-hoc signing.
Summary by CodeRabbit
改进
Bug Fixes
Build Improvements