forked from sadopc/ScreenCapture
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add PaddleOCR as VLM provider with fast/precise modes #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: hubo1989/ScreenTranslate
Length of output: 1254
🏁 Script executed:
Repository: hubo1989/ScreenTranslate
Length of output: 745
🏁 Script executed:
Repository: hubo1989/ScreenTranslate
Length of output: 712
🏁 Script executed:
rg -n "hasPermission|permissionDenied|SCShareableContent\.current" ScreenTranslate/Features/Capture/CaptureManager.swiftRepository: hubo1989/ScreenTranslate
Length of output: 470
🏁 Script executed:
Repository: hubo1989/ScreenTranslate
Length of output: 3136
🏁 Script executed:
Repository: hubo1989/ScreenTranslate
Length of output: 1374
🏁 Script executed:
rg -n "ScreenTranslateError" ScreenTranslate/Features/Capture/CaptureManager.swiftRepository: hubo1989/ScreenTranslate
Length of output: 1103
hasPermission将所有异常统一映射为false,掩盖实际错误信息第 55-60 行的
catch块捕获SCShareableContent.current的所有异常并无区别地返回false,导致第 92 行和 161 行的调用方都将其解释为权限拒绝(permissionDenied)。这会将网络错误、系统级故障等非权限问题误报为权限问题。对比
getSCDisplay方法(第 246-258 行)的做法,它在同一调用上使用了正确的错误处理模式:throw ScreenTranslateError.captureFailure(underlying: error),保留底层错误信息供调用方判断。建议hasPermission也按此模式优化,区分权限错误和其他故障,避免错误信息丢失。🤖 Prompt for AI Agents