test: harden translation pipeline regressions

ScreenTranslate/App/Coordinators/TextTranslationCoordinator.swift

@@ -117,7 +117,7 @@ final class TextTranslationCoordinator {
 
             // Step 3: Translate the captured text
             if #available(macOS 13.0, *) {
-                let config = await TextTranslationConfig.fromAppSettings()
+                let config = TextTranslationConfig.fromAppSettings()
                 let translationResult = try await TextTranslationFlow.shared.translate(
                     selectionResult.text,
                     config: config
@@ -203,7 +203,7 @@ final class TextTranslationCoordinator {
 
         do {
             if #available(macOS 13.0, *) {
-                let config = await TextTranslationConfig.forTranslateAndInsert()
+                let config = TextTranslationConfig.forTranslateAndInsert()
                 let translationResult = try await TextTranslationFlow.shared.translate(selectedText, config: config)
                 translatedText = translationResult.translatedText
 

ScreenTranslate/Features/Capture/ScreenDetector.swift

@@ -1,10 +1,12 @@
 import Foundation
 @preconcurrency import ScreenCaptureKit
 import AppKit
+import os
 
 /// Service responsible for enumerating connected displays using ScreenCaptureKit.
 /// Thread-safe actor that provides display discovery and matching with NSScreen.
 actor ScreenDetector {
+    private let logger = Logger.capture
     // MARK: - Types
 
     /// Error types specific to screen detection
@@ -129,18 +131,18 @@ actor ScreenDetector {
         // Quick check first using CGPreflightScreenCaptureAccess
         guard CGPreflightScreenCaptureAccess() else {
             cachedPermissionStatus = false
-            if !silent { print("[ScreenDetector] Permission check: denied (CGPreflight)") }
+            if !silent { logger.debug("Permission check: denied (CGPreflight)") }
             return false
         }
         // Actually verify by trying to get shareable content
         do {
             _ = try await SCShareableContent.current
             cachedPermissionStatus = true
-            if !silent { print("[ScreenDetector] Permission check: granted") }
+            if !silent { logger.debug("Permission check: granted") }
             return true
         } catch {
             cachedPermissionStatus = false
-            if !silent { print("[ScreenDetector] Permission check: denied (SCShareableContent)") }
+            if !silent { logger.debug("Permission check: denied (SCShareableContent)") }
             return false
         }
     }

ScreenTranslate/Features/Preview/AnnotationCanvas.swift

@@ -1,13 +1,15 @@
 import SwiftUI
 import AppKit
 import CoreImage
+import os
 
 /// SwiftUI Canvas view for drawing and displaying annotations.
 /// Renders existing annotations and in-progress drawing.
 struct AnnotationCanvas: View {
     // MARK: - Shared CIContext for performance
 
     private static let sharedCIContext = CIContext()
+    private static let logger = Logger.ui
 
     // MARK: - Properties
 
@@ -399,14 +401,14 @@ struct AnnotationCanvas: View {
 
         // Apply pixelation using CIPixellate filter
         guard let pixellateFilter = CIFilter(name: "CIPixellate") else {
-            print("[Mosaic] Warning: CIPixellate filter not available, falling back to gray block")
+            Self.logger.warning("CIPixellate filter not available, falling back to gray block")
             return nil
         }
         pixellateFilter.setValue(ciImage, forKey: kCIInputImageKey)
         pixellateFilter.setValue(max(1, blockSize), forKey: kCIInputScaleKey)
 
         guard let outputImage = pixellateFilter.outputImage else {
-            print("[Mosaic] Warning: Pixellation failed, falling back to gray block")
+            Self.logger.warning("Pixellation failed, falling back to gray block")
             return nil
         }
 

ScreenTranslate/Features/Settings/CompatibleEngineConfigSheet.swift

@@ -239,7 +239,6 @@ struct CompatibleEngineConfigSheet: View {
             let provider = try await CompatibleTranslationProvider(
                 config: engineConfig,
                 compatibleConfig: tempConfig,
-                instanceIndex: index,
                 keychain: KeychainService.shared
             )
 

ScreenTranslate/Features/Settings/EngineConfigSheet.swift

@@ -6,6 +6,7 @@
 //
 
 import SwiftUI
+import os
 
 struct EngineConfigSheet: View {
     let engine: TranslationEngineType
@@ -21,6 +22,7 @@ struct EngineConfigSheet: View {
     @State private var isTesting = false
     @State private var testResult: String?
     @State private var testSuccess = false
+    private let logger = Logger.settings
 
     var body: some View {
         VStack(spacing: 20) {
@@ -339,7 +341,7 @@ struct EngineConfigSheet: View {
                     )
                 }
             } catch {
-                print("Failed to save credentials: \(error)")
+                logger.error("Failed to save credentials: \(error.localizedDescription, privacy: .private(mask: .hash))")
             }
         }
     }

ScreenTranslate/Features/Settings/MultiEngineSettingsSection.swift

@@ -495,21 +495,11 @@ struct MultiEngineSettingsSection: View {
     private func deleteCompatibleEngine(at index: Int) {
         Task {
             do {
-                let compositeId = "custom:\(index)"
-                try await KeychainService.shared.deleteCredentials(forCompatibleId: compositeId)
-
-                // Shift credentials for remaining engines
-                for i in (index + 1)..<viewModel.settings.compatibleProviderConfigs.count {
-                    let oldId = "custom:\(i)"
-                    let newId = "custom:\(i - 1)"
-                    if let creds = try? await KeychainService.shared.getCredentials(forCompatibleId: oldId) {
-                        try await KeychainService.shared.saveCredentials(apiKey: creds.apiKey, forCompatibleId: newId)
-                        try await KeychainService.shared.deleteCredentials(forCompatibleId: oldId)
-                    }
-                }
+                let config = viewModel.settings.compatibleProviderConfigs[index]
+                try await KeychainService.shared.deleteCredentials(forCompatibleId: config.keychainId)
 
                 // Clear cached provider for this engine
-                await TranslationEngineRegistry.shared.removeCompatibleProvider(for: compositeId)
+                await TranslationEngineRegistry.shared.removeCompatibleProvider(for: config.keychainId)
 
                 await MainActor.run {
                     viewModel.settings.compatibleProviderConfigs.remove(at: index)
@@ -531,10 +521,8 @@ struct MultiEngineSettingsSection: View {
     private func setCompatibleAsEngineAtIndex(config: CompatibleTranslationProvider.CompatibleConfig, index: Int) {
         Task {
             do {
-                let configIndex = viewModel.settings.compatibleProviderConfigs.firstIndex(where: { $0.id == config.id }) ?? 0
                 let provider = try await TranslationEngineRegistry.shared.createCompatibleProvider(
-                    compatibleConfig: config,
-                    index: configIndex
+                    compatibleConfig: config
                 )
 
                 let isAvailable = await provider.isAvailable
@@ -562,10 +550,8 @@ struct MultiEngineSettingsSection: View {
     private func appendCompatibleAsEngine(config: CompatibleTranslationProvider.CompatibleConfig) {
         Task {
             do {
-                let configIndex = viewModel.settings.compatibleProviderConfigs.firstIndex(where: { $0.id == config.id }) ?? 0
                 let provider = try await TranslationEngineRegistry.shared.createCompatibleProvider(
-                    compatibleConfig: config,
-                    index: configIndex
+                    compatibleConfig: config
                 )
 
                 let isAvailable = await provider.isAvailable
@@ -594,10 +580,8 @@ struct MultiEngineSettingsSection: View {
         Task {
             do {
                 // Create provider to verify configuration
-                let index = viewModel.settings.compatibleProviderConfigs.firstIndex(where: { $0.id == config.id }) ?? 0
                 let provider = try await TranslationEngineRegistry.shared.createCompatibleProvider(
-                    compatibleConfig: config,
-                    index: index
+                    compatibleConfig: config
                 )
 
                 // Verify availability

ScreenTranslate/Features/Settings/PromptSettingsView.swift

@@ -99,7 +99,7 @@ struct PromptSettingsView: View {
                     .font(.subheadline)
                     .foregroundStyle(.secondary)
 
-                ForEach(Array(viewModel.settings.compatibleProviderConfigs.enumerated()), id: \.element.id) { index, config in
+                ForEach(viewModel.settings.compatibleProviderConfigs) { config in
                     HStack {
                         Image(systemName: "gearshape.2")
                             .frame(width: 24)
@@ -109,14 +109,14 @@ struct PromptSettingsView: View {
                         Spacer()
 
                         // Show if custom prompt is set
-                        if let prompt = viewModel.settings.promptConfig.compatibleEnginePrompts[index], !prompt.isEmpty {
+                        if let prompt = viewModel.settings.promptConfig.compatibleEnginePrompts[config.id.uuidString], !prompt.isEmpty {
                             Image(systemName: "pencil.circle.fill")
                                 .foregroundStyle(.tint)
                         }
 
                         Button(localized("prompt.button.edit")) {
-                            editingTarget = .compatibleEngine(index)
-                            editingPrompt = viewModel.settings.promptConfig.compatibleEnginePrompts[index] ?? ""
+                            editingTarget = .compatibleEngine(config.id.uuidString, config.displayName)
+                            editingPrompt = viewModel.settings.promptConfig.compatibleEnginePrompts[config.id.uuidString] ?? ""
                         }
                         .buttonStyle(.bordered)
                         .controlSize(.small)
@@ -212,11 +212,11 @@ struct PromptSettingsView: View {
             } else {
                 config.enginePrompts[engine] = prompt
             }
-        case .compatibleEngine(let index):
+        case .compatibleEngine(let promptID, _):
             if prompt.isEmpty {
-                config.compatibleEnginePrompts.removeValue(forKey: index)
+                config.compatibleEnginePrompts.removeValue(forKey: promptID)
             } else {
-                config.compatibleEnginePrompts[index] = prompt
+                config.compatibleEnginePrompts[promptID] = prompt
             }
         case .scene(let scene):
             if prompt.isEmpty {
@@ -251,15 +251,15 @@ struct PromptSettingsView: View {
 
 enum PromptEditTarget: Identifiable {
     case engine(TranslationEngineType)
-    case compatibleEngine(Int)
+    case compatibleEngine(String, String)
     case scene(TranslationScene)
 
     var id: String {
         switch self {
         case .engine(let engine):
             return "engine-\(engine.rawValue)"
-        case .compatibleEngine(let index):
-            return "compatible-\(index)"
+        case .compatibleEngine(let promptID, _):
+            return "compatible-\(promptID)"
         case .scene(let scene):
             return "scene-\(scene.rawValue)"
         }
@@ -269,8 +269,8 @@ enum PromptEditTarget: Identifiable {
         switch self {
         case .engine(let engine):
             return engine.localizedName
-        case .compatibleEngine(let index):
-            return "Compatible Engine \(index + 1)"
+        case .compatibleEngine(_, let displayName):
+            return displayName
         case .scene(let scene):
             return scene.localizedName
         }