Add reregister() function #1628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register session handlers for use with USP SSO authentication plugin.
nkissebe
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable registration of session handlers for use with USP SSO authentication plugin. A single function is added, called reregister().
Motivation
This change is needed for the plugin development described in this card: https://sdx-sdsc.atlassian.net/browse/USP-54
Testing
This code was used on a development instance where the plugin was written. Both proof of concept and acceptance testing were performed on the instance: HUBzero developers and USP staff verified that the USP SSO plugin functions properly.
Hotfix
This hotfix should be included on the USP production instance in order to make rollout of SSO possible there. See https://sdx-sdsc.atlassian.net/browse/USP-69
PR checklist
[x] Make sure there are links in the PR to the source JIRA card(s) and hubzero ticket(s)
[x] Include a brief summary of the issue in your own words
[x] Include a brief summary of the fix/changed code
[x] Include a brief summary of your testing. What did you specifically do to investigate that this change has the correct results?
[x] Indicate if the change needs to be hotfixed to any production hubs before a normal core rollout
[] Double check someone is assigned to review the ticket