Also demote privileges for text editing utils #312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches subprocess creation and privilege/UID handling, which can affect sandboxing, permissions, and cross-platform behavior (especially root-in-container vs. Windows).
Overview
Introduces a shared
get_demote_preexec_fn()incoding/utils.pyto standardize subprocess isolation: on Unix it usessetsidand, when running as root, demotes to uid/gid 1000; on Windows it returnsNone.Updates
ClaudeBashSession(bash.py), the sharedBashSession(session.py), and asyncread_file_async/write_file_asyncto use this helper instead of inline, platform-specific process creation logic, removing duplicatedos/sysbranching.Written by Cursor Bugbot for commit b2a64ea. This will update automatically on new commits. Configure here.