Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes how connector copies are created and rewrites HUD-specific request headers, which could affect remote MCP session/environment routing if assumptions differ across servers. Scope is limited and covered by new unit tests for HUD vs non-HUD behavior.
Overview
Ensures
Connector.copy()produces fully isolated state for parallel eval traces by deep-copying the transport and cloningConnectionConfiglist fields, rather than reusing shared mutable objects.For HUD MCP servers only,
copy()now normalizesEnvironment-Namecasing and generates a freshEnvironment-Id(UUID) per copied connector to prevent environment/session state leaking across concurrent contexts. Adds tests validating transport/config isolation and that HUD connectors get unique environment IDs while non-HUD connectors keep existing env/session headers.Written by Cursor Bugbot for commit 903421e. This will update automatically on new commits. Configure here.