Builds Refactor#389
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a72f47e5dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 60b4430. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes core
hud buildflow and lockfile generation, including new--push/buildx output handling, which could affect image availability for analysis and produced lock contents. Also updates deploy build trigger endpoint/payload, which may break compatibility if backend expectations differ.Overview
Build and analysis output has been standardized and refactored. A new shared
hud.cli.utils.analysis.analyze_environmentreturns a build-readyBuildAnalysisshape (addsinitializeMs,toolCount,internalToolCount,success,hubTools, and scenario derivation) andhud analyzenow measures client init time and consumeshubTools(camelCase) instead ofhub_tools.hud buildnow always usesdocker buildx buildwith passthrough Docker flags (provided after--), auto-adds--loadunless an output mode is explicitly chosen, and supports--pushby pushing, then pulling for local analysis. Lockfile generation is centralized in newhud.cli.utils.lockfile.build_lock_data/dump_lock_data, and runtime probing metadata capture was removed.Deploy trigger API updated. The direct deploy flow now POSTs to
/builds/trigger(withsource: "direct") instead of/builds/trigger-direct. Tests were updated and new unit tests were added for the shared analysis/lockfile helpers.Reviewed by Cursor Bugbot for commit 5e7f151. Bugbot is set up for automated code reviews on this repo. Configure here.