Fix checkValid error #145
Merged
Merged
Conversation
Owner
There was a problem hiding this comment.
cannot be
return form && form.$valid ?
Collaborator
Author
There was a problem hiding this comment.
return form && form.$valid will return undefined or null instead of false, in case of the form is undefined or null respectively. I just want this function to return boolean as we expected.
Owner
There was a problem hiding this comment.
!!(form && form.$valid) more understandable?
Owner
There was a problem hiding this comment.
whatever it is, should be okay 😄
Collaborator
Author
There was a problem hiding this comment.
It's the same for me, but I could change it if you want.
Owner
|
👍 Small change makes perfect 👍 |
Collaborator
Author
|
Done! Need your confirmation. If it's ok, I'll merge it now. :) |
Owner
|
when travis ready, then sure 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed an error when no argument, undefined, or null passed to the checkValid function.