New Feature: custom Message Element & update parameter for setErrorHTML() & setSuccessHTML()

[hung-doan]

New feature:

• Add new function: $validationProvider.addMsgElement()
• Add new function: $validationProvider.getMsgElement()

Update feature:
From

$validationProvider.setErrorHTML(function(msg){
});

$validationProvider.setSuccessHTML(function(msg){
});

To

$validationProvider.setErrorHTML(function(msg, element, attrs){
});

$validationProvider.setSuccessHTML(function(msg, element, attrs){
});

[hueitan]

👍 This looks good @hungdoan2

See the comment.

[hueitan]

Do you mind giving more description about add/getMsgElement ?

This is difficult to understand,

1. Show the default message element
2. Show the example why we use addMsgElement

[hung-doan]

ok

[hueitan]

Also, I would like to add a line

Please make sure that you understand the usage before using add/getMsgElement

[hueitan]

It will be perfect if you can squash your commit into more readable message. 🍺

[hueitan]

@hungdoan2 I'm ready to merge the commit after you finish.

[hung-doan]

@huei90 already squashed all commits & update document.
About document I think It will be easier to follow If there is a navigation bar in document page , which will show all the API/Feature need, like this: http://angular-ui.github.io/ui-router/site/#/api/ui.router

[hueitan]

Please rebase the master lastest code.

navigation bar

Yes, this is the ticket I'm working on.

[hung-doan]

@huei90 already rebased :)

[hueitan]

@hungdoan2 This should be rebased too. the $compile.

[hung-doan]

@huei90 hope this commit work 💪

[hueitan]

@hungdoan2 Yes this works perfectly 🍻

[hueitan]

@lvarayut I'm going to merge this commit, please review.

[lvarayut]

Could you explain more in plain English? For example, "You could use this addMsgElement to ... It reduces your effort of manually putting `message-id" so on and so forth.

[lvarayut]

@hungdoan2 Would you mind to provide some unit tests covering your new functions?

[hueitan]

@hungdoan2 I can do the unit tests job if you want me to do it.

[hung-doan]

@huei90 Thanks you, I'm glad to hear that, Would u might helping me with these test cases! . Actually I got a trouble with grunt test: It always show Can not load "PhantomJS", it is not registered!. even I installed all phantom packages. I'm checking it now.

[hueitan]

@hungdoan2 try npm install, else uninstall -g phantomjs and try install again.

---

@hungdoan2 This is a big feature for us, so it takes time to complete all the tasks before merging.

[hung-doan]

@huei90 ok, I will complete my task in this week 💪 . and I'm sorry to rush you^^

[hueitan]

@hungdoan2 No worry 😄

[hueitan]

This is fine 😄 👍

[hung-doan]

👍

[hueitan]

This commit is almost done, I'm going to merge it now.