A-assertions #3
Merged
A-assertions #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add assertions to the BMO, Storage and TaskList classes Several methods in these classes require important assumptions to hold true in order for the program to run. Assertions for these conditions to the code helps the debugging process. Let's add assertions to these classes.
Parse parse method is too long and handles both input type checking and input format checking. Having smaller methods to handle the different types of possible inputs makes the code more readable. Let's update the parser method to handle only input type checking, and abstract out input format checking to appropriate methods.
Add assertions to Deadlines and Events classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.