Skip to content

Conversation

@seongminn
Copy link
Member

🌍 이슈 번호

✅ 작업 내용

  • 게임 목록의 리그 팀 리스트 필터를 쿼리 키로 등록할 때, 정렬된 값을 추가합니다.
    • 이 때, 쿼리 키 값이 '2,5,8,11,13,15'과 같이 문자열로 등록되는데, 라이브러리 내부에서 단순 일치 연산으로 쿼리 키를 비교하고 있습니다. 그래서 ['2', '5', ... ]처럼 배열로 비교하는 것에 비해 오히려 성능이 좋을 것 같아 그대로 추가했습니다.

📝 참고 자료

♾️ 기타

@seongminn seongminn added the performance Performance improvements label Mar 19, 2024
@seongminn seongminn self-assigned this Mar 19, 2024
@netlify
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for hufscheer ready!

Name Link
🔨 Latest commit 585f528
🔍 Latest deploy log https://app.netlify.com/sites/hufscheer/deploys/65f98e188d77c80008d74cb7
😎 Deploy Preview https://deploy-preview-108--hufscheer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 56
Accessibility: 71
Best Practices: 83
SEO: 55
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for hufscheer-manager ready!

Name Link
🔨 Latest commit 585f528
🔍 Latest deploy log https://app.netlify.com/sites/hufscheer-manager/deploys/65f98e18c3e8d800086cd377
😎 Deploy Preview https://deploy-preview-108--hufscheer-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ohprettyhak ohprettyhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정렬을 통해 해결하셨군요! 고생하셨습니다.

Copy link
Contributor

@HiimKwak HiimKwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쿼리키 팩토리를 추가하면 다 뜯어서 고쳐야하니까 필요한 부분에만 정렬로 일관성을 유지하는 전략 매우 좋습니다! 나중에 잠잠해지면 쿼리키 팩토리를 붙여도 좋을 것 같아요! 고생하셨습니다 ㅎㅎ

@seongminn seongminn merged commit af07461 into main Mar 19, 2024
@seongminn seongminn deleted the perf/query-key branch March 19, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PERF] 게임 목록 쿼리 캐시 일관성 보장

4 participants