[FEAT] 매니저 앱 대회 경기 관리 구현 #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
✅ Deploy Preview for hufscheer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hufscheer-manager ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
seongminn
approved these changes
Mar 19, 2024
Comment on lines
+17
to
+20
| ':hover': { | ||
| backgroundColor: theme.colors.gray[2], | ||
| color: theme.colors.primary[3], | ||
| }, |
Member
There was a problem hiding this comment.
selectors 프로퍼티를 이용해야 하는 줄 알았는데 아닌가보네요!👍
Contributor
Author
There was a problem hiding this comment.
https://vanilla-extract.style/documentation/styling/ 해당 페이지에서 hover를 위와 같이 사용하더라구요!
Contributor
Author
There was a problem hiding this comment.
말씀하신 부분은 모두 적용해놓았습니다. 코드를 쭉 보니까 쿼리 혹은 뮤테이션에 파라미터를 넣을 때 string, number 타입이 혼재되어 사용되더라구요. 이 부분도 추후에 통일하면 더욱 좋을 거 같습니다. 따로 노션에 정리하겠습니다.
Co-authored-by: Seongmin Choi <88662637+seongminn@users.noreply.github.com>
Co-authored-by: Seongmin Choi <88662637+seongminn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌍 이슈 번호
✅ 작업 내용
📝 참고 자료
♾️ 기타