[REFACTOR] order & fconline 관련 기능 제거 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hufscheer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ohprettyhak
approved these changes
Mar 3, 2024
Contributor
ohprettyhak
left a comment
ohprettyhak
left a comment
There was a problem hiding this comment.
odd, even 등 이번 변경으로 인해 뜻이 더 명확해졌네요. 고생하셨습니다 😀
말씀하신 cheerTalkType의 경우 제가 작업하고 있어 제 이슈에서 반영하도록 하겠습니다.
HiimKwak
approved these changes
Mar 3, 2024
Contributor
HiimKwak
left a comment
HiimKwak
left a comment
There was a problem hiding this comment.
제가 작성한 lineup 컴포넌트에서도 blue냐 red냐를 whichSide란 prop으로 관리하고 있는데, 이 코드처럼 쿼리 훅에서부터 direction을 따로 계산해 data로 포함시켜 넘겨주는 방식으로 리팩토링해도 괜찮을 것 같네요. 나중에 여유 있을 때 반영하도록 하겠습니다 좋은 코드 감사합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌍 이슈 번호
✅ 작업 내용
📝 참고 자료
♾️ 기타
{ direction: 'left' | 'right'; logoImageUrl: string }을 넣어두었습니다. 일단 배포를 우선시 하고, 추후 리팩토링 하면서 수정하려 했습니다. 혹시나 이 부분 작업하시는 분이 있다면 해당 타입까지 함께 리팩토링 해주시면 감사하겠습니다🙇♂️🙇♂️🙇♂️