Skip to content

Conversation

@Sherlock113
Copy link
Contributor

Add a blog post to explain how to use BentoML to deploy Hugging Face models with DeepFloyd IF as an example. See #1280 for details.

@Sherlock113
Copy link
Contributor Author

@sayakpaul @osanseviero PTAL. Thanks!

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're already on a great start! Left a couple of minor comments.

@sayakpaul sayakpaul requested review from pcuenca and philschmid July 31, 2023 04:20
Copy link
Contributor

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this amazing blog post! I left two suggestions. Since this is meant to be a guest post for the open-source integration of diffusers with bentoML, it would be good if we avoid advertising your paid solutions. Would you mind removing or reworking that section.

Let me know if you have any other questions!

@sayakpaul
Copy link
Member

@osanseviero @pcuenca could you review it once? I think it's good to go.

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool blog post!

@Sherlock113 Sherlock113 requested a review from philschmid August 8, 2023 23:41
@sayakpaul
Copy link
Member

Hey @Sherlock113!

The additional image present in assets needs to go to https://huggingface.co/datasets/huggingface/documentation-images. We only keep the thumbnail images in that folder these days. So I hosted that here: https://huggingface.co/datasets/huggingface/documentation-images/tree/main/blog/deploy-deepfloydif-using-bentoml. Could you please delete that image from assets and update the link wherever necessary?

@Sherlock113
Copy link
Contributor Author

Hey @Sherlock113!

The additional image present in assets needs to go to https://huggingface.co/datasets/huggingface/documentation-images. We only keep the thumbnail images in that folder these days. So I hosted that here: https://huggingface.co/datasets/huggingface/documentation-images/tree/main/blog/deploy-deepfloydif-using-bentoml. Could you please delete that image from assets and update the link wherever necessary?

Thanks. I just fixed it.

@sayakpaul
Copy link
Member

@philschmid could you approve so that we can merge?

Copy link
Contributor

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving it! :)

@sayakpaul sayakpaul merged commit 8a2540d into huggingface:main Aug 9, 2023
@Sherlock113 Sherlock113 deleted the sherlock/deploy-deepfloydif-using-bentoml branch August 9, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants