Skip to content

Conversation

@dylanebert
Copy link
Contributor

No description provided.

@dylanebert dylanebert requested a review from pcuenca September 26, 2024 21:22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a textured mess (j/k)

@dylanebert
Copy link
Contributor Author

dylanebert commented Sep 27, 2024

Thanks a lot @pcuenca! I agree with all comments and believe I've addressed them.

I've updated the release date to Monday

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

import trimesh

mesh = trimesh.load("output.glb")
mesh.show()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we wanna show a screenshot here?

import cv2
import numpy as np
import trimesh
import xatlas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love sorted imports 🔥

display(image_texture)
```

![Texture with holes](https://github.com/dylanebert/InstantTexture/blob/main/notebooks/tex_output_1.png?raw=true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please host the images in the doc images dataset on the Hub as the other blogs

display(image_texture)
```

![Texture without holes](https://github.com/dylanebert/InstantTexture/blob/main/notebooks/tex_output_2.png?raw=true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@dylanebert dylanebert force-pushed the vertex-colored-to-textured-mesh branch from 7150472 to e2fa258 Compare September 30, 2024 20:02
@dylanebert dylanebert merged commit 92bfadf into main Sep 30, 2024
1 check passed
@dylanebert dylanebert deleted the vertex-colored-to-textured-mesh branch September 30, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants