Skip to content

Conversation

@jiqing-feng
Copy link
Contributor

Hi @echarlaix . Please review it.

@jiqing-feng jiqing-feng marked this pull request as draft October 16, 2025 08:51
@jiqing-feng jiqing-feng marked this pull request as ready for review October 16, 2025 08:54
@jiqing-feng
Copy link
Contributor Author

jiqing-feng commented Oct 16, 2025

Formulas showns as

image image

@echarlaix

Copy link
Contributor

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jiqing-feng !


$$normalized\\_throughput\\_per\\_vCPU = (throughput\\_C4 / vCPUs\\_C4) / (throughput\\_C3 / vCPUs\\_C3)$$
$$
normalized\text{\_}throughput\text{\_}per\text{\_}vCPU = \frac{throughput\text{\_}C4 / vCPUs\text{\_}C4}{throughput\text{\_}C3 / vCPUs\text{\_}C3}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echarlaix
Copy link
Contributor

I think there is an issue still that needs to be fixed before we can merge @jiqing-feng https://github.com/jiqing-feng/blog/blob/fix_gpt_oss/gpt-oss-on-intel-xeon.md#results

@jiqing-feng
Copy link
Contributor Author

Yes, I am looking at it. It's weird cause it shown correctly in the VSCode preview mode. How did you get the result? BTW, do you know any other blogs that introduce formulas so I can refer? Thanks

@jiqing-feng
Copy link
Contributor Author

Hi @echarlaix . Could you please try it again to get the result? Thanks!

@echarlaix echarlaix merged commit a0125a0 into huggingface:main Oct 16, 2025
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
pcuenca added a commit that referenced this pull request Oct 16, 2025
Related: #3129
@pcuenca pcuenca mentioned this pull request Oct 16, 2025
jiqing-feng and others added 2 commits October 16, 2025 17:27
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
echarlaix pushed a commit that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants