Add missing MochiEncoder3D.gradient_checkpointing attribute#11146
Merged
a-r-r-o-w merged 4 commits intoApr 5, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
@bot/ style |
a-r-r-o-w
reviewed
Mar 31, 2025
Comment on lines
+83
to
+89
| @unittest.skip("Unsupported test.") | ||
| def test_effective_gradient_checkpointing(self): | ||
| """ Fails because of conv_cache: | ||
| tests/models/autoencoders/test_models_autoencoder_mochi.py::AutoencoderKLMochiTests::test_effective_gradient_checkpointing - | ||
| TypeError: ModelMixin.enable_gradient_checkpointing.<locals>._gradient_checkpointing_func() got an unexpected keyword argument 'conv_cache' | ||
| """ | ||
| pass |
Contributor
There was a problem hiding this comment.
I think this test should be made to pass. It fails because we don't accept kwargs in gradient checkpointing func:
Could you update the vae implementation to not pass conv_cache argument as a keyword arg and instead just use normal arg? LMK if you'd like me to take this up in a separate PR. Other than, changes LGTM, thanks!
Contributor
|
@bot /style |
Contributor
|
Style fixes have been applied. View the workflow run here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes
MochiEncoder3Dis missing thegradient_checkpointingattribute in current main:src/src/diffusers/models/autoencoders/autoencoder_kl_mochi.py causing the forward pass to fail withAttributeError: 'MochiEncoder3D' object has no attribute 'gradient_checkpointing'. We simply addedself.gradient_checkpointing = FalseinMochiEncoder3D.Also a limited set of tests were added for
AutoencoderKLMochi: there are a number of tests we skip, but we feel fixing those are not in the scope of this PR.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.