Skip to content

[train_text_to_image_sdxl]Add LANCZOS as default interpolation mode for image resizing#11455

Merged
asomoza merged 8 commits into
huggingface:mainfrom
ParagEkbote:Improve-Image-Interpolation
May 5, 2025
Merged

[train_text_to_image_sdxl]Add LANCZOS as default interpolation mode for image resizing#11455
asomoza merged 8 commits into
huggingface:mainfrom
ParagEkbote:Improve-Image-Interpolation

Conversation

@ParagEkbote
Copy link
Copy Markdown
Contributor

@ParagEkbote ParagEkbote commented Apr 29, 2025

What does this PR do?

Refs #11390

As mentioned in the issue, I've updated LANCZOS as the default interpolation mode for the training script. Please let me know if any modifications are required and I will make the necessary changes.

Before submitting

Who can review?

@asomoza

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Member

@asomoza asomoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just a minor correction

Comment thread examples/text_to_image/train_text_to_image_sdxl.py Outdated
Co-authored-by: Álvaro Somoza <asomoza@users.noreply.github.com>
@ParagEkbote ParagEkbote requested a review from asomoza April 30, 2025 06:55
@asomoza
Copy link
Copy Markdown
Member

asomoza commented May 2, 2025

thanks @ParagEkbote, as a final step, for contributing in diffusers you have to format the code, can you run these two commands on the console:

make style
make quality

If for some reason you can't run them, I can run a bot that does this for you, but it's always better to run it yourself, specially for larger contributions of code with multiple reviews.

@ParagEkbote
Copy link
Copy Markdown
Contributor Author

I have run both the commands for code quality and linting. Could you please review the changes?

cc: @asomoza

@asomoza asomoza merged commit fc5e906 into huggingface:main May 5, 2025
9 checks passed
@ParagEkbote ParagEkbote deleted the Improve-Image-Interpolation branch May 5, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants