[train_text_to_image_sdxl]Add LANCZOS as default interpolation mode for image resizing#11455
Merged
asomoza merged 8 commits intoMay 5, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
asomoza
reviewed
Apr 29, 2025
Member
asomoza
left a comment
There was a problem hiding this comment.
thanks, just a minor correction
Co-authored-by: Álvaro Somoza <asomoza@users.noreply.github.com>
Member
|
thanks @ParagEkbote, as a final step, for contributing in diffusers you have to format the code, can you run these two commands on the console: If for some reason you can't run them, I can run a bot that does this for you, but it's always better to run it yourself, specially for larger contributions of code with multiple reviews. |
Contributor
Author
|
I have run both the commands for code quality and linting. Could you please review the changes? cc: @asomoza |
asomoza
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refs #11390
As mentioned in the issue, I've updated LANCZOS as the default interpolation mode for the training script. Please let me know if any modifications are required and I will make the necessary changes.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@asomoza