🌐 [i18n-KO] Translated `conceptual/philosophy.md` and 3 other documents to Korean #8294

mreraser · 2024-05-28T04:13:00Z

What does this PR do?

Hello!😀

Translated
conceptual/contribution.md
conceptual/ethical_guidelines.md
conceptual/evaluation.md
conceptual/philosophy.md
file of the documentation to Korean.

Started from #7940

Thank you so much for your valuable review.

Before reviewing

Check for missing / redundant translations (번역 누락/중복 검사)
Grammar Check (맞춤법 검사)
Check Inline TOC (e.g. [[lowercased-header]])
Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

I have great respect for your previous contributions, and I would really appreciate if @wonhyeongseo and the PseudoLab group could review this.

@jungnerd, @heuristicwave, @harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae

Before submitting

This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline?
Did you read our philosophy doc (important for complex PRs)?
Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
Did you write any new necessary tests?

Who can review? (Final)

Hello @stevhliu and @sayakpaul!
Thank you for all your hard work and efforts. I would really appreciate if you could review this.

stevhliu

Great job in translating such long and dense docs! The structure looks good to me and once PseudoLab has reviewed the actual translation, we can merge 🤗

docs/source/ko/conceptual/contribution.md

cjfghk5697

HuggingFace Python Library에 참고하여 일단 메서드 -> 메소드, 저장소 ->리포지토리로 변경했습니다!

docs/source/ko/conceptual/ethical_guidelines.md

docs/source/ko/conceptual/philosopy.md

docs/source/ko/conceptual/ethical_guidelines.md

jungnerd

philosophy.md 일부 리뷰했으니 확인 부탁드립니다!

docs/source/ko/conceptual/philosopy.md

jungnerd · 2024-05-29T07:56:00Z

docs/source/ko/conceptual/philosopy.md

+## 성능보다는 사용성을
+
+- Diffusers는 많은 내장 성능 향상 기능을 갖고 있지만 (자세한 내용은 [메모리와 속도](https://huggingface.co/docs/diffusers/optimization/fp16) 참조), 모델은 항상 가장 높은 정밀도와 최소한의 최적화로 로드됩니다. 따라서 기본적인 diffusion 파이프라인은 따로 정의하지 않는다면 CPU에서 float32 정밀도로 인스턴스화됩니다. 이는 다양한 플랫폼과 가속기에서의 사용성을 보장하며, 라이브러리를 실행하기 위해 복잡한 설치가 필요하지 않음을 의미합니다.
+- Diffusers는 **가벼운** 패키지를 지향하며, 따라서 매우 적은 필수 종속성이 있고, 대신에 성능을 향상시킬 수 있는 많은 선택적 종속성이 있습니다 (`accelerate`, `safetensors`, `onnx` 등). 우리는 라이브러리를 가능한 한 가볍게 유지하여 다른 패키지와의 종속성으로 인해 걱정할 필요가 없도록 노력합니다.


Suggested change

- Diffusers는 **가벼운** 패키지를 지향하며, 따라서 매우 적은 필수 종속성이 있고, 대신에 성능을 향상시킬 수 있는 많은 선택적 종속성이 있습니다 (`accelerate`, `safetensors`, `onnx` 등). 우리는 라이브러리를 가능한 한 가볍게 유지하여 다른 패키지와의 종속성으로 인해 걱정할 필요가 없도록 노력합니다.

- Diffusers는 **가벼운** 패키지를 지향하기 때문에필수 종속성은 거의 없지만 성능을 향상시킬 수 있는 많은 선택적 종속성이 있습니다 (`accelerate`, `safetensors`, `onnx` 등). 저희는 라이브러리를 가능한 한 가볍게 유지하여 다른 패키지에 대한 종속성 걱정이 없도록 노력하고 있습니다.

지향하기 때문에V필수 종속성은 거의 없지만 : '때문에'와 '필수' 사이에 띄어쓰기가 되어야 할 것 같습니다!

나머지는 너무 좋은 것 같습니다, 리뷰 감사합니다! 👍

mreraser · 2024-05-29T08:25:59Z

philosophy.md 일부 리뷰했으니 확인 부탁드립니다!

넵 확인하였습니다! 감사합니다 ☺️

docs/source/ko/conceptual/ethical_guidelines.md

Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com>

HuggingFaceDocBuilderDev · 2024-05-31T16:12:10Z

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

docs/source/ko/conceptual/evaluation.md

Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr>

stevhliu · 2024-06-12T15:50:52Z

Feel free to let me know when you've addressed all the feedback and are ready to merge! 🤗

mreraser · 2024-06-12T16:04:10Z

Feel free to let me know when you've addressed all the feedback and are ready to merge! 🤗

Thank you! I believe I've addressed all the feedback and am ready for the merge. I appreciate all your hard work :)

stevhliu

Thanks again for the contribution and to @heuristicwave, @cjfghk5697 and @jungnerd for the review! 🤗

#8294 (#8690) * Update philosophy.md Some contributions were not reflected previously, so I am resubmitting them. * Update docs/source/ko/conceptual/philosophy.md Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * Update docs/source/ko/conceptual/philosophy.md Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

…flected on #8294 (#8914) fix_ethical_guidelines.md

…d on #8294 (#8938) * incorrect_number_fix * add_TOC * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * fix: manual edits * fix: manual edtis * fix: manual edits * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * fix: manual edits --------- Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com>

…ts to Korean (#8294) * translation about 3 documents into Korean * evaluation doc korean translation * _toctree.yml modify * doc title fix : philosopy->philosophy * Update docs/source/ko/conceptual/ethical_guidelines.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/ethical_guidelines.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/ethical_guidelines.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/ethical_guidelines.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/ethical_guidelines.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/ethical_guidelines.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/ethical_guidelines.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/ethical_guidelines.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/ethical_guidelines.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/ethical_guidelines.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/evaluation.md Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr> * Update docs/source/ko/conceptual/evaluation.md Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr> * Update docs/source/ko/conceptual/evaluation.md Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr> * Update docs/source/ko/conceptual/evaluation.md Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr> * Update docs/source/ko/conceptual/evaluation.md Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr> * Update docs/source/ko/conceptual/evaluation.md Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr> * Update docs/source/ko/conceptual/evaluation.md Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr> * Update philosophy.md (from jungnerd) --------- Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr>

#8294 (#8690) * Update philosophy.md Some contributions were not reflected previously, so I am resubmitting them. * Update docs/source/ko/conceptual/philosophy.md Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * Update docs/source/ko/conceptual/philosophy.md Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

…flected on #8294 (#8914) fix_ethical_guidelines.md

…d on #8294 (#8938) * incorrect_number_fix * add_TOC * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * fix: manual edits * fix: manual edtis * fix: manual edits * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com> * fix: manual edits --------- Co-authored-by: Jihun Lim <31366038+heuristicwave@users.noreply.github.com>

mreraser added 3 commits May 27, 2024 03:08

translation about 3 documents into Korean

5a37ae8

evaluation doc korean translation

3d207e3

_toctree.yml modify

c1e0657

sayakpaul requested a review from stevhliu May 28, 2024 04:45

mreraser force-pushed the translation_ko branch from 5de6697 to c1e0657 Compare May 28, 2024 16:36

stevhliu reviewed May 28, 2024

View reviewed changes

docs/source/ko/conceptual/contribution.md Show resolved Hide resolved

cjfghk5697 reviewed May 29, 2024

View reviewed changes

docs/source/ko/conceptual/ethical_guidelines.md Outdated Show resolved Hide resolved

docs/source/ko/conceptual/philosopy.md Show resolved Hide resolved

docs/source/ko/conceptual/philosopy.md Show resolved Hide resolved

docs/source/ko/conceptual/philosopy.md Show resolved Hide resolved

heuristicwave reviewed May 29, 2024

View reviewed changes

docs/source/ko/conceptual/ethical_guidelines.md Show resolved Hide resolved