[SD3 Inference] T5 Token limit#8506
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Closed
Member
Author
|
the failing test is not from this PR |
yiyixuxu
approved these changes
Jun 14, 2024
sayakpaul
reviewed
Jun 16, 2024
sayakpaul
reviewed
Jun 16, 2024
sayakpaul
reviewed
Jun 16, 2024
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks for the prompt PR. I left some questions. Overall this looks good to me. My only concern is that we're introducing a change that might lead to different results for the same prompt.
Collaborator
|
@asomoza can we add a section to the doc (in a new PR)? |
6 tasks
yiyixuxu
added a commit
that referenced
this pull request
Jun 20, 2024
* max_sequence_length for the T5 * updated img2img * apply suggestions --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com> Co-authored-by: YiYi Xu <yixu310@gmail.com>
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* max_sequence_length for the T5 * updated img2img * apply suggestions --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com> Co-authored-by: YiYi Xu <yixu310@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an argument
max_sequence_lengthto set the token limit for the T5.Prompt:
I did a quick test with enabling long prompts for the clip models but it didn't make any noticeable difference, so for now this PR will only enable the long prompt for the T5 to avoid adding more code and complexity to the pipeline.
Who can review?
Anyone in the community is free to review