Skip to content

[Core] remove resume_download from Hub related stuff #8648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 18, 2024
Merged

[Core] remove resume_download from Hub related stuff #8648

merged 10 commits into from
Jul 18, 2024

Conversation

@sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Jun 20, 2024

What does this PR do?

To not have to incur:

huggingface_hub/file_download.py:1132: FutureWarning: `resume_download` is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use `force_download=True`.

@sayakpaul sayakpaul requested review from DN6, Wauplin and yiyixuxu June 20, 2024 11:09
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 20, 2024

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Wauplin

This comment was marked as duplicate.

Sign in to view

Wauplin
Wauplin approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of removing those @sayakpaul. I'm linking #7843 and #8267 which are related PRs (the ones that should have already removed the deprecation warnings). Removing resume_download altogether is even better since it'll also us to remove it from huggingface_hub in the future.

Last thing: do you want to remove resume_download mention from docstrings as well? We have this message for now but if we remove them already, then let's remove the docs as well?

@sayakpaul
Copy link
Member Author

sayakpaul commented Jun 26, 2024

@Wauplin removed from docstrings as well.

Wauplin
Wauplin approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DN6
Copy link
Collaborator

DN6 commented Jul 17, 2024

@sayakpaul We can merge once the conflicts are resolved here

@sayakpaul
Copy link
Member Author

sayakpaul commented Jul 18, 2024

Failing tests are unrelated.

@sayakpaul sayakpaul merged commit e02ec27 into main Jul 18, 2024
@sayakpaul sayakpaul deleted the remove-resume-download branch July 18, 2024 04:18
Disty0 pushed a commit to Disty0/diffusers that referenced this pull request Jul 18, 2024
@sayakpaul @Disty0
[Core] remove resume_download from Hub related stuff (huggingface#8648
2b153a6 
)

* remove resume_download

* fix: _fetch_index_file call.

* remove resume_download from docs.
sayakpaul added a commit that referenced this pull request Dec 23, 2024
@sayakpaul
[Core] remove resume_download from Hub related stuff (#8648)
11307ce 
* remove resume_download

* fix: _fetch_index_file call.

* remove resume_download from docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wauplin Wauplin Wauplin approved these changes

@DN6 DN6 Awaiting requested review from DN6

@yiyixuxu yiyixuxu Awaiting requested review from yiyixuxu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sayakpaul @HuggingFaceDocBuilderDev @DN6 @Wauplin