Allow from_transformer in SD3ControlNetModel #8749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyixuxu
reviewed
Jul 1, 2024
Collaborator
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
thanks!
I think only the transformer_blocks need strict=False though - other layers should be exact matches so that's remove the strict=False where it is not needed
Co-authored-by: YiYi Xu <yixu310@gmail.com>
Co-authored-by: YiYi Xu <yixu310@gmail.com>
Co-authored-by: YiYi Xu <yixu310@gmail.com>
Contributor
Author
|
@yiyixuxu Done. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
* Update controlnet_sd3.py --------- Co-authored-by: YiYi Xu <yixu310@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #8723.
Currently, in
SD3ControlNetModel.from_transformer(), thenum_layersis None by default. If we don't set num_layers manually, it will lead to size mismatch error at the last block. Some explanations can be found here.