Skip to content

Conversation

@DN6
Copy link
Collaborator

@DN6 DN6 commented Aug 20, 2024

What does this PR do?

Legacy kwargs prediction_type and scheduler_type will not be configured in single file loading if an appropriate model config is present in the users cache. This leads bad samples being generated if the user would like to change the prediction type for a particular model.

This PR:

  1. Adds an additional check to trigger legacy scheduler loading when these kwargs are passed in
  2. Updates the deprecation message for these kwargs with examples to show how we expect the schedulers to be configured in single file loading going forward.

Fixes # (issue)
#9171

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@DN6 DN6 merged commit 750bd79 into main Aug 21, 2024
@yiyixuxu yiyixuxu deleted the sf-legacy-support branch August 21, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants