Skip to content

Conversation

@asomoza
Copy link
Member

@asomoza asomoza commented Aug 26, 2024

What does this PR do?

This PR makes the loading of the image_encoder use the same cache_dir and local_files_only arguments from the IPA model loading which is the expected behavior.

Fixes #9192

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yiyixuxu @jonahclarsen

@asomoza asomoza requested a review from yiyixuxu August 26, 2024 04:46
@asomoza asomoza changed the title [IP Adapter] Fix cache dir and local files for image encoders [IP Adapter] Fix cache_dir and local_files_only for image encoder Aug 26, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit 4cfb216 into huggingface:main Aug 26, 2024
@asomoza asomoza deleted the ipa-image-encoder-cache branch August 26, 2024 19:52
asomoza added a commit that referenced this pull request Aug 30, 2024
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

load_ip_adapter() doesn't respect cache_dir or local_files_only

3 participants