-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Slight performance improvement to Euler, EDMEuler, FlowMatchHeun, KDPM2Ancestral
#9616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hlky love the attention you're giving schedulers. btw, a bit off-topic, but though of mentioning it here:
|
Euler, EDMEuler, FlowMatchHeun, KDPM2Ancestral
|
Thanks! Looks like that cast and the mentioned precision issues comes from |
that options is so rarely used that moving cast only if its true should be more than ok. |
yiyixuxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
some of the tests failed as expected because the random seeds are used differently now
|
|
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…`, `KDPM2Ancestral` (#9616) * Slight performance improvement to Euler * Slight performance improvement to EDMEuler * Slight performance improvement to FlowMatchHeun * Slight performance improvement to KDPM2Ancestral * Update KDPM2AncestralDiscreteSchedulerTest --------- Co-authored-by: YiYi Xu <yixu310@gmail.com>
What does this PR do?
This PR provides a slight performance improvement to
Euler,EDMEuler,FlowMatchHeunby moving creation ofrandntensornoiseto inside thegamma > 0condition.gamma, calculated asmin(s_churn / (len(self.sigmas) - 1), 2**0.5 - 1) if s_tmin <= sigma <= s_tmax else 0.0is generally0.0ass_churn,s_tminands_tmaxare typically not changed from their default values of0.0,0.0andinfrespectively.Similarly in
KDPM2Ancestralwe move creation ofnoiseto inside the 2nd order path.Who can review?
@yiyixuxu