Rope in float32 for mps or npu compatibility #12665
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Nov 14, 2025
| def rope(self, pos: torch.Tensor, dim: int, theta: int) -> torch.Tensor: | ||
| assert dim % 2 == 0 | ||
| scale = torch.arange(0, dim, 2, dtype=torch.float64, device=pos.device) / dim | ||
| scale = torch.arange(0, dim, 2, dtype=torch.float32, device=pos.device) / dim |
Member
There was a problem hiding this comment.
Does it not affect any quality?
Contributor
Author
There was a problem hiding this comment.
Images are not exactly identical but I think it is OK.
Left: float32, right: float64
Member
There was a problem hiding this comment.
Hmm, just to be a bit more future-proof, WDYT the change from https://github.com/huggingface/diffusers/pull/11316/files?
Contributor
Author
There was a problem hiding this comment.
Sure, I changed for what was suggested.
DavidBert
force-pushed
the
fix-mps-npu
branch
from
613f87c to
d15c317
Compare
DavidBert
force-pushed
the
fix-mps-npu
branch
from
d15c317 to
c3c8e06
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
Failing tests are unrelated. Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12653
(changing for Rope dtype for float32 does not degrade quality)
Who can review?
@sayakpaul