[CI] Temporarily pin transformers #12677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Nov 18, 2025
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
uv pip uninstall transformers huggingface_hub && uv pip install --prerelease allow -U transformers@git+https://github.com/huggingface/transformers.git
This is still installing from main no?
sayakpaul
reviewed
Nov 18, 2025
.github/workflows/nightly_tests.yml
Outdated
| uv pip install -e ".[quality]" | ||
| uv pip uninstall accelerate && uv pip install -U accelerate@git+https://github.com/huggingface/accelerate.git | ||
| #uv pip uninstall transformers huggingface_hub && uv pip install --prerelease allow -U transformers@git+https://github.com/huggingface/transformers.git | ||
| uv pip uninstall transformers huggingface_hub && uv pip install transformers |
Member
There was a problem hiding this comment.
But we don't need this step no? The Docker container should already have a stable version of transformers installed? 👀
Collaborator
Author
There was a problem hiding this comment.
sayakpaul
approved these changes
Nov 18, 2025
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
I would say we keep it uniform and do uv pip uninstall transformers huggingface_hub && uv pip install transformers==4.57.1 everywhere applicable?
Member
|
Failing tests seem unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Temporarily pin transformers (and by extension hf_hub) to version 4.57.1 and 0.36. This is to reduce noise in our CI while transformers is under going refactors for 5.0.0. We can unpin after the next Diffusers release.
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.