Skip to content

Conversation

@DavidBert
Copy link
Contributor

@DavidBert DavidBert commented Dec 4, 2025

What does this PR do?

Realized there was a discrepancy between our internal timestep embedding and the version used in Diffusers.
Setting downscale_freq_shift = 0 aligns both implementations and makes the embeddings fully equivalent.

Before submitting

Who can review?

@sayakpaul, @yiyixuxu and @asomoza

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DavidBert DavidBert changed the title PRX fix downscale_freq_shift when computing timesteps embeddings PRX Set downscale_freq_shift to 0 for consistency with internal implementation Dec 4, 2025
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu merged commit 8d415a6 into huggingface:main Dec 4, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants