Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jan 23, 2023

Adding revision allow module import directly from HF hub as many models already have flax versions as a branch. Save steps is also very useful. This should make the script more applicable for all users.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@ghost ghost marked this pull request as draft January 24, 2023 00:47
@ghost ghost marked this pull request as ready for review January 24, 2023 00:49
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@patil-suraj what do you think?

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@patil-suraj
Copy link
Contributor

The style tests are failing. Could you just run make style and push the changes? That should fix it and then it's good for merge :)

@patil-suraj patil-suraj self-assigned this Jan 25, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Feb 25, 2023
@patrickvonplaten
Copy link
Contributor

Merging and running make style after

@patrickvonplaten patrickvonplaten merged commit f3f626d into huggingface:main Mar 6, 2023
mengfei25 pushed a commit to mengfei25/diffusers that referenced this pull request Mar 27, 2023
…ag (huggingface#2075)

* Update textual_inversion_flax.py

* Update textual_inversion_flax.py

* Typo

sorry.

* Format source
w4ffl35 pushed a commit to w4ffl35/diffusers that referenced this pull request Apr 14, 2023
…ag (huggingface#2075)

* Update textual_inversion_flax.py

* Update textual_inversion_flax.py

* Typo

sorry.

* Format source
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…ag (huggingface#2075)

* Update textual_inversion_flax.py

* Update textual_inversion_flax.py

* Typo

sorry.

* Format source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Issues that haven't received updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants